Add infrastructure for loading certs on the server #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Makefile has been updated to improve the way it handles '.go' files. The changes include: - Adjusted the GO_SRC variable to exclude './' from the start of file paths. - Added new targets under .make/tidy/ for each Go module (gen, provider, sdk, tests) to ensure their dependencies are tidied up correctly.
- Introduced a new function to load certificates for TLS configuration - Added a new option in the provisioner struct for gRPC server options - Modified the New function to include these server options when creating a new gRPC server - Created an opt function WithTLS that appends TLS credentials to the gRPC server options - Renamed RegisterCommandServiceServer and State functions for better readability
Two new utility functions have been added to the opts package. The NoOp function is a no-operation function that returns an error-free function for any type. The If function takes a boolean predicate and an option, returning the option if the predicate is true or a no-op otherwise.
Significant changes include: - Added error handling to the 'New' function in the provisioner package. - Introduced new functions for setting gRPC options and TLS configuration. - Created a function to handle optional certificates, which only applies if all certificate files are provided. - Refactored existing functions to use these new option-setting functions.
The provisioner's main.go file has been updated to enhance the logging system. The log level is now set based on the verbose flag, and error messages have been improved for better clarity. Additionally, support for optional certificates (CA, server certificate, and private key) has been introduced. These can be provided via new command line flags: 'ca-file', 'cert-file', and 'key-file'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.