fix: generated self-referencing CSS variables #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect output like blow:
fix #81
TODO: Add tests.The existing tests cannot identify this issue. I referred to https://github.com/unocss/unocss/blob/main/packages/runtime/test-dom/runtime-dom.test.ts and attempted the
runtime-dom
vitest tests, but they also failed to detect this problem.Regarding the unit test, I wasn't able to find a better solution, so I had to resort to comparing the bundled CSS output.
My approach to fixing the issue is to check whether the CSS variable already exists when assigning it. If it does, the existing value will be used rather than generating a new one.