Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing Uno Logo in Image #1017

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Conversation

morning4coffe-dev
Copy link
Member

@morning4coffe-dev morning4coffe-dev commented Sep 23, 2023

GitHub Issue (If applicable): closes unoplatform/uno#11676

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

The SVG Image inside Image sample is missing on Android and iOS, after moving to WinUI.

What is the new behavior?

image

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested on iOS.
  • Tested on Wasm.
  • Tested on Android.
  • Tested on Windows
    (currently having some unrelated issues there with build due to Lottie, on master)
  • Tested in both Light and Dark themes.
  • Associated with an issue (GitHub or internal)

Copy link
Contributor

@Xiaoy312 Xiaoy312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could just replace the file, without renaming it, no?

@morning4coffe-dev
Copy link
Member Author

@Xiaoy312 Sure! 👍 In this case probably the best to revert the changes on the deletion and just leave it there

@kazo0
Copy link
Contributor

kazo0 commented Oct 23, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

github-actions bot commented Nov 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1017.eastus2.3.azurestaticapps.net

@MartinZikmund MartinZikmund merged commit b19f99c into master Nov 1, 2023
15 checks passed
@MartinZikmund MartinZikmund deleted the dev/doti/missing-svg-fix branch November 1, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Gallery][iOS]Image- Uno Image is missing for 'SVG Image' option.
6 participants