-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling overlay elements modification to make use of ShadowContainer #583
base: master
Are you sure you want to change the base?
Handling overlay elements modification to make use of ShadowContainer #583
Conversation
testing incomplete
@pictos can we both take a look at this today? |
UI/UnoZIndex/UnoZIndex/UnoZIndex/UnoZIndex/Presentation/MainPage.xaml
Outdated
Show resolved
Hide resolved
UI/UnoZIndex/UnoZIndex/UnoZIndex/UnoZIndex/Presentation/MainPage.xaml
Outdated
Show resolved
Hide resolved
UI/UnoZIndex/UnoZIndex/UnoZIndex/UnoZIndex/Presentation/MainPage.xaml
Outdated
Show resolved
Hide resolved
UI/UnoZIndex/UnoZIndex/UnoZIndex/UnoZIndex/Presentation/MainPage.xaml.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running the wasm version I got this error:
C:\Users\Jesus.nuget\packages\uno.wasm.bootstrap\7.0.29\build\Uno.Wasm.Bootstrap.targets(206,3): error : System.InvalidOperationException: The current PowerShell Execution policy is [AllSigned]. To run the bootstrapper, open an elevated PowerShell prompt and run
Set-ExecutionPolicy RemoteSigned -Force
C:\Users\Jesus.nuget\packages\uno.wasm.bootstrap\7.0.29\build\Uno.Wasm.Bootstrap.targets(206,3): error : at Uno.Wasm.Bootstrap.ShellTask_v7cfaa83637b88e75f852b4f9ff988785083bc2b1.ValidatPowershellExecutionPolicy() in D:\a\1\s\src\Uno.Wasm.Bootstrap\ShellTask.cs:line 1315
C:\Users\Jesus.nuget\packages\uno.wasm.bootstrap\7.0.29\build\Uno.Wasm.Bootstrap.targets(206,3): error : at Uno.Wasm.Bootstrap.ShellTask_v7cfaa83637b88e75f852b4f9ff988785083bc2b1.ValidateEmscripten() in D:\a\1\s\src\Uno.Wasm.Bootstrap\ShellTask.cs:line 1218
C:\Users\Jesus.nuget\packages\uno.wasm.bootstrap\7.0.29\build\Uno.Wasm.Bootstrap.targets(206,3): error : at Uno.Wasm.Bootstrap.ShellTask_v7cfaa83637b88e75f852b4f9ff988785083bc2b1.RunPackager() in D:\a\1\s\src\Uno.Wasm.Bootstrap\ShellTask.cs:line 783
C:\Users\Jesus.nuget\packages\uno.wasm.bootstrap\7.0.29\build\Uno.Wasm.Bootstrap.targets(206,3): error : at Uno.Wasm.Bootstrap.ShellTask_v7cfaa83637b88e75f852b4f9ff988785083bc2b1.Execute() in D:\a\1\s\src\Uno.Wasm.Bootstrap\ShellTask.cs:line 263
I tried to run the command on Powershell but didn't work.
On Android, there's a different behavior than Windows.
When I click/tap on the card it doesn't move to be above all the rest, like happens on Windows.
The background color doesn't respect the theme, as you can see in the screenshot:
First issue: did you run the power shell as an admin? It should be run in elevated mode. Second issue: there seems to be an issue with Canvas SetIndex methods on Android >= 32. It works on iOS, Mac OS, WASM and Windows. |
Yeah, I did that as an admin and didn't work for wasm. Probably something on my env. I could run it on Android, but I've to set the manifest manually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR @Onotseike , sorry for taking so long to do the final review
Removed ElevatedView in favor of the new ShadowContainer