Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single proj Migration: Maui community toolkit app #749

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Kunal22shah
Copy link
Contributor

@Kunal22shah Kunal22shah commented Jun 7, 2024

@Kunal22shah Kunal22shah self-assigned this Jun 7, 2024
@kazo0
Copy link
Contributor

kazo0 commented Jun 7, 2024

@Kunal22shah I am seeing an error on the splashscreen where we should be seeing a ProgressRing:

Screenshot_1717770619

It's this error: https://platform.uno/docs/articles/uno-build-error-codes.html#unox0001

We will need to add the Lottie dependency as described in the docs

Comment on lines 10 to 11
<PackageVersion Include="Microsoft.Maui.Controls" Version="$(MauiVersion)" />
<PackageVersion Include="Microsoft.Maui.Controls.Compatibility" Version="$(MauiVersion)" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing MauiVersion defined anywhere

Copy link
Contributor

@agneszitte agneszitte Jun 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazo0 the MauiVersion is not defined anymore with the latest template. It is automatic with Uno.Sdk.
I don't think we need to add explicitly the versions here (cc @jeromelaban, @dansiegel)

@Kunal22shah Kunal22shah requested a review from kazo0 June 7, 2024 16:49
Comment on lines +10 to +12
<PackageVersion Include="Microsoft.Maui.Controls" Version="8.0.21" />
<PackageVersion Include="Microsoft.Maui.Controls.Compatibility" Version="8.0.21" />
<PackageVersion Include="Microsoft.Maui.Graphics" Version="8.0.21" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cf. comment here #749 (comment)

Comment on lines +36 to +47
<UnoFeatures>
Hosting;
Toolkit;
Logging;
MauiEmbedding;
MVUX;
Configuration;
Http;
Serialization;
Localization;
Navigation;
</UnoFeatures>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazo0, as the project was created with a version based on the recommended preset, maybe we can clean and remove the unnecessary UnoFeatures here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants