-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single proj Migration: Maui community toolkit app #749
base: master
Are you sure you want to change the base?
Conversation
@Kunal22shah I am seeing an error on the splashscreen where we should be seeing a ProgressRing: It's this error: https://platform.uno/docs/articles/uno-build-error-codes.html#unox0001 We will need to add the Lottie dependency as described in the docs |
<PackageVersion Include="Microsoft.Maui.Controls" Version="$(MauiVersion)" /> | ||
<PackageVersion Include="Microsoft.Maui.Controls.Compatibility" Version="$(MauiVersion)" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing MauiVersion
defined anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kazo0 the MauiVersion is not defined anymore with the latest template. It is automatic with Uno.Sdk.
I don't think we need to add explicitly the versions here (cc @jeromelaban, @dansiegel)
...yToolkitApp/MauiCommunityToolkitApp.MauiControls/MauiCommunityToolkitApp.MauiControls.csproj
Outdated
Show resolved
Hide resolved
UI/MauiEmbedding/MauiCommunityToolkitApp/MauiCommunityToolkitApp/MauiCommunityToolkitApp.csproj
Outdated
Show resolved
Hide resolved
UI/MauiEmbedding/MauiCommunityToolkitApp/MauiCommunityToolkitApp/MauiCommunityToolkitApp.csproj
Outdated
Show resolved
Hide resolved
UI/MauiEmbedding/MauiCommunityToolkitApp/MauiCommunityToolkitApp/MauiCommunityToolkitApp.csproj
Outdated
Show resolved
Hide resolved
UI/MauiEmbedding/MauiCommunityToolkitApp/MauiCommunityToolkitApp/MauiCommunityToolkitApp.csproj
Show resolved
Hide resolved
<PackageVersion Include="Microsoft.Maui.Controls" Version="8.0.21" /> | ||
<PackageVersion Include="Microsoft.Maui.Controls.Compatibility" Version="8.0.21" /> | ||
<PackageVersion Include="Microsoft.Maui.Graphics" Version="8.0.21" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cf. comment here #749 (comment)
...bedding/MauiCommunityToolkitApp/MauiCommunityToolkitApp.MauiControls/AppBuilderExtensions.cs
Show resolved
Hide resolved
...bedding/MauiCommunityToolkitApp/MauiCommunityToolkitApp.MauiControls/AppBuilderExtensions.cs
Show resolved
Hide resolved
<UnoFeatures> | ||
Hosting; | ||
Toolkit; | ||
Logging; | ||
MauiEmbedding; | ||
MVUX; | ||
Configuration; | ||
Http; | ||
Serialization; | ||
Localization; | ||
Navigation; | ||
</UnoFeatures> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kazo0, as the project was created with a version based on the recommended preset, maybe we can clean and remove the unnecessary UnoFeatures
here
#146