Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Move AdvancedXBind to SingleProject Uno.Sdk 5.3 #797

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore: Move AdvancedXBind to SingleProject Uno.Sdk 5.3 #797

wants to merge 4 commits into from

Conversation

morning4coffe-dev
Copy link
Member

image

@morning4coffe-dev morning4coffe-dev mentioned this pull request Aug 3, 2024
Closed
@morning4coffe-dev
Copy link
Member Author

CC @agneszitte, the sample seems to work well with the features on all platforms, but when having it in dark theme, the background still stays white as it is set and no components are visible. It is the same behavior as before tho.

agneszitte
agneszitte reviewed Aug 15, 2024
View reviewed changes
Copy link
Contributor

@agneszitte agneszitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morning4coffe-dev please add a readme file for the sample if there is none at the moment

UI/AdvancedXBind/AdvancedXBind/AdvancedXBind/AdvancedXBind/AdvancedXBind.csproj Outdated Show resolved Hide resolved
@agneszitte
Copy link
Contributor

CC @agneszitte, the sample seems to work well with the features on all platforms, but when having it in dark theme, the background still stays white as it is set and no components are visible. It is the same behavior as before tho.

@morning4coffe-dev if it the same behavior with the old version of the sample we can merge those changes when the last fixes are done. Just make sure to open an issue if there is none already to track this issue please

@morning4coffe-dev
Copy link
Member Author

@agneszitte Readme added and I can confirm it is also an issue on master #814

@morning4coffe-dev morning4coffe-dev marked this pull request as ready for review August 16, 2024 13:06
@agneszitte agneszitte mentioned this pull request Sep 27, 2024
Closed
agneszitte
agneszitte reviewed Sep 27, 2024
View reviewed changes
UI/AdvancedXBind/AdvancedXBind/AdvancedXBind/global.json
{
// To update the version of Uno please update the version of the Uno.Sdk here. See https://aka.platform.uno/upgrade-uno-packages for more information.
"msbuild-sdks": {
"Uno.Sdk": "5.3.96"
Copy link
Contributor

@agneszitte agneszitte Sep 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will need to be rebased with latest and updated to latest 5.4 stable version
Related new issue: #828

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will need to be rebased with latest and updated to latest 5.5 stable version
Related new issue: #848

@agneszitte agneszitte mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@agneszitte agneszitte agneszitte left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@morning4coffe-dev @agneszitte @Youssef1313