Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include word is used Two times. #1274

Closed
Darsh0307 opened this issue Nov 6, 2023 · 6 comments
Closed

Include word is used Two times. #1274

Darsh0307 opened this issue Nov 6, 2023 · 6 comments
Labels
good first issue Good for newcomers kind/documentation Improvements or additions to documentation low-prio

Comments

@Darsh0307
Copy link
Contributor

On which page?

https://platform.uno/docs/articles/external/uno.themes/doc/themes-overview.html

Screenshot 2023-11-06 at 10 46 42 AM

What's wrong?

The "Include" word is used Twice

Any feedback?

I think that changing the line to "Both libraries help you style your application with just a few lines of code, including:" will make more sense

@Darsh0307 Darsh0307 added kind/documentation Improvements or additions to documentation good first issue Good for newcomers low-prio labels Nov 6, 2023
@Darsh0307 Darsh0307 assigned Darsh0307 and unassigned Darsh0307 Nov 6, 2023
@sfazli96
Copy link

sfazli96 commented Nov 7, 2023

Hi! I might be able to find where the double word is coming from and delete it. I can take a look. I am a first-timer contributor still learning.

@agneszitte
Copy link
Contributor

agneszitte commented Nov 8, 2023

Hi! I might be able to find where the double word is coming from and delete it. I can take a look. I am a first-timer contributor still learning.

Hi @sfazli96 welcome!
We will happily accept your contribution to this issue. Here is our Contribution Guide for all the details.
As it is detailed in it, your commit must be in the Conventional Commits format please.

Here is the updated sentence that we should have in this case instead:
Both libraries help you style your application with a few lines of code, including:

And here is the current related code:

Both libraries help you style your application with a few lines of code include and include:

Please let us know if you have any additional questions or blockers and we will be happy to help you!

@sfazli96
Copy link

sfazli96 commented Nov 8, 2023

Ok I made a pull request and fixed the wording.

@agneszitte agneszitte linked a pull request Nov 8, 2023 that will close this issue
6 tasks
@agneszitte
Copy link
Contributor

agneszitte commented Nov 8, 2023

Ok I made a pull request and fixed the wording.

Thank you a lot for your PR @sfazli96, it is really appreciated!
I left you a comment #1279 (comment)

@sfazli96
Copy link

yeah I saw the comment and updated the title.

@morning4coffe-dev
Copy link
Member

CC @agneszitte, @Darsh0307 Closing this issue as it was fixed by #1308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/documentation Improvements or additions to documentation low-prio
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants