Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed duplicate word in themes-overview.md #1279

Closed
wants to merge 4 commits into from

Conversation

sfazli96
Copy link

@sfazli96 sfazli96 commented Nov 8, 2023

GitHub Issue: #

PR Type

What kind of change does this PR introduce?
Just refactoring a sentence/code update formatting, repeated word include to including

Description

The change was that in themes-overviews.md I updated the sentence from a repeated word to just one-word fix.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2023

CLA assistant check
All committers have signed the CLA.

@agneszitte agneszitte linked an issue Nov 8, 2023 that may be closed by this pull request
@agneszitte
Copy link
Contributor

@sfazli96 thank you a lot for your PR, I approved the changes.
As I mentioned here, your commit must be in the Conventional Commits format please.
image
So if you can update and replace your current commit with a similar commit message please:

- fixed repeated word include twice to including in themes-overview.md
+ docs: Fixed duplicate word in themes-overview.md

@sfazli96 sfazli96 changed the title fixed repeated word include twice to including in themes-overview.md Fixed duplicate word in themes-overview.md Nov 12, 2023
@kazo0
Copy link
Collaborator

kazo0 commented Nov 16, 2023

@sfazli96 thanks for the PR!

It looks like the Conventional Commits check is still failing because you need to prefix your commit message with an appropriate type, such as fix: or docs:

@sfazli96
Copy link
Author

ok, I see so do i have to make another commit, that's where I am just a little confused. Please explain

@agneszitte
Copy link
Contributor

ok, I see so do i have to make another commit, that's where I am just a little confused. Please explain

@sfazli96 you will need to adjust the current commit (as conventional commit will still fail if there is still a commit without the proper prefix). Here is the related documentation so you can learn how to adjust your commit message :)
https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message

Let us know if you have additional questions

@iurycarlos
Copy link
Contributor

Hello @sfazli96 !
Thanks for your help :)

So, the easiest way to go is to rebase your branch to the Master.
Then, add a commit named with docs: prefix, for instance:

"docs: Fixing duplicated text" or the way you prefer most.

Right now, the current branch has, unnecessarily 4 commits, which could cause a small confusion.

Feel free to ping me if you need more info!

@agneszitte
Copy link
Contributor

@sfazli96 gentle ping for this PR. Please let @iurycarlos or me know if you still need help adjusting your commit so we can merge the changes. Thanks again for your contribution

@sfazli96
Copy link
Author

@iurycarlos Hi, can you adjust the commit so you can merge the changes please? Thank you!

@iurycarlos iurycarlos mentioned this pull request Dec 15, 2023
12 tasks
@iurycarlos
Copy link
Contributor

iurycarlos commented Dec 15, 2023

Ok! @sfazli96 !
I created a new PR so you can compare both. ( #1308 )
It is the same fix, but with just one commit.
The commit title is now following Conventional Commits https://www.conventionalcommits.org/en/v1.0.0/#summary

@Darsh0307
Copy link
Contributor

This PR got closed Automatically because the PR (#1308) was merged
Thank you very much @sfazli96 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include word is used Two times.
6 participants