-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed duplicate word in themes-overview.md #1279
Conversation
@sfazli96 thank you a lot for your PR, I approved the changes. - fixed repeated word include twice to including in themes-overview.md
+ docs: Fixed duplicate word in themes-overview.md |
@sfazli96 thanks for the PR! It looks like the Conventional Commits check is still failing because you need to prefix your commit message with an appropriate type, such as |
ok, I see so do i have to make another commit, that's where I am just a little confused. Please explain |
@sfazli96 you will need to adjust the current commit (as conventional commit will still fail if there is still a commit without the proper prefix). Here is the related documentation so you can learn how to adjust your commit message :) Let us know if you have additional questions |
Hello @sfazli96 ! So, the easiest way to go is to rebase your branch to the Master. "docs: Fixing duplicated text" or the way you prefer most. Right now, the current branch has, unnecessarily 4 commits, which could cause a small confusion. Feel free to ping me if you need more info! |
@sfazli96 gentle ping for this PR. Please let @iurycarlos or me know if you still need help adjusting your commit so we can merge the changes. Thanks again for your contribution |
@iurycarlos Hi, can you adjust the commit so you can merge the changes please? Thank you! |
Ok! @sfazli96 ! |
GitHub Issue: #
PR Type
What kind of change does this PR introduce?
Just refactoring a sentence/code update formatting, repeated word include to including
Description
The change was that in themes-overviews.md I updated the sentence from a repeated word to just one-word fix.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):