Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add MediaPlayerElement styles and sample pages #1042

Merged
merged 2 commits into from
Sep 29, 2023
Merged

feat: Add MediaPlayerElement styles and sample pages #1042

merged 2 commits into from
Sep 29, 2023

Conversation

nguyeenvy
Copy link
Contributor

@nguyeenvy nguyeenvy commented Jun 27, 2023 •
edited
Loading

closes #1032

GitHub Issue: #1032

PR Type

What kind of change does this PR introduce?

  • Feature

Description

Add MediaPlayerElement styles and sample pages

PR Checklist

Other Information

@nguyeenvy nguyeenvy requested review from Marc-Antoine-Soucy and kazo0 and removed request for Marc-Antoine-Soucy June 27, 2023 15:51
@github-actions
Copy link

github-actions bot commented Jun 27, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1042.eastus2.azurestaticapps.net

@nguyeenvy nguyeenvy force-pushed the dev/maso/materialmediaplayer branch from 7c36795 to bf08fe9 Compare August 8, 2023 16:15
@github-actions
Copy link

github-actions bot commented Aug 8, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1042.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 8, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1042.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 8, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1042.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 8, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1042.eastus2.azurestaticapps.net

@nguyeenvy nguyeenvy force-pushed the dev/maso/materialmediaplayer branch from 095f33d to 69cde4f Compare August 8, 2023 17:39
@github-actions
Copy link

github-actions bot commented Aug 8, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1042.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 11, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1042.eastus2.azurestaticapps.net

pictos
pictos reviewed Aug 11, 2023
View reviewed changes
Copy link
Contributor

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've just a small comment

...WP/Uno.Themes.Samples.Shared/Content/NestedSamples/MediaPlayerElementSample_NestedPage5.xaml Outdated Show resolved Hide resolved
@nguyeenvy nguyeenvy force-pushed the dev/maso/materialmediaplayer branch from 6652ccd to ebf6a85 Compare August 14, 2023 03:37
@agneszitte
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

kazo0
kazo0 reviewed Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@kazo0 kazo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we're going to need to bump the WinAppSDK version to at least 1.2 in order to have support for MediaTransportControls (https://learn.microsoft.com/en-us/windows/windows-app-sdk/api/winrt/microsoft.ui.xaml.controls.mediatransportcontrols?view=windows-app-sdk-1.3#applies-to)

FYI @agneszitte / @Xiaoy312

@agneszitte
Copy link
Contributor

Also when this PR is merged @kazo0, @Xiaoy312, @nguyeenvy we will need to add more samples for the Gallery app

@nguyeenvy nguyeenvy force-pushed the dev/maso/materialmediaplayer branch from 7f15542 to 88abc79 Compare August 21, 2023 21:32
@nguyeenvy nguyeenvy requested a review from kazo0 August 22, 2023 15:48
@nguyeenvy nguyeenvy requested a review from pictos August 22, 2023 15:48
@github-actions
Copy link

github-actions bot commented Aug 22, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1042.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 22, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1042.eastus2.azurestaticapps.net

@kazo0
Copy link
Collaborator

kazo0 commented Aug 23, 2023

@nguyeenvy let's bump the versions of Microsoft.WindowsAppSDK to 1.2.0

@github-actions
Copy link

github-actions bot commented Aug 23, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1042.eastus2.azurestaticapps.net

@nguyeenvy nguyeenvy force-pushed the dev/maso/materialmediaplayer branch from aa27e69 to 4e74244 Compare August 23, 2023 18:35
@nguyeenvy
Copy link
Contributor Author

@kazo0 Microsoft.WindowsAppSDK has been successfully bumped to 1.2.0

@github-actions
Copy link

github-actions bot commented Aug 23, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1042.eastus2.azurestaticapps.net

2 similar comments
@github-actions
Copy link

github-actions bot commented Aug 23, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1042.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 23, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1042.eastus2.azurestaticapps.net

@agneszitte agneszitte mentioned this pull request Aug 25, 2023
Open
1 task
@agneszitte
Copy link
Contributor

Also when this PR is merged @kazo0, @Xiaoy312, @nguyeenvy we will need to add more samples for the Gallery app

I have opened an issue for it unoplatform/Uno.Gallery#909

@Marc-Antoine-Soucy Marc-Antoine-Soucy force-pushed the dev/maso/materialmediaplayer branch from 9304e2c to 8df75c0 Compare September 28, 2023 17:04
@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1042.eastus2.azurestaticapps.net

@kazo0 kazo0 force-pushed the dev/maso/materialmediaplayer branch from 5003bf4 to bb3e61a Compare September 28, 2023 19:07
@kazo0 kazo0 enabled auto-merge (squash) September 28, 2023 19:08
@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1042.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1042.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 29, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1042.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit 6bebcc0 into master Sep 29, 2023
10 checks passed
@kazo0 kazo0 deleted the dev/maso/materialmediaplayer branch September 29, 2023 16:18
@sasakrsmanovic
Copy link

@nguyeenvy Thanks for that PR. I don't recall if I or @mtmattei had sent you an Uno Platform t-shirt as a small token of appreciation for the contribution. If not , please get in touch with me at sasha at platform . uno. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pictos pictos pictos left review comments

@kazo0 kazo0 kazo0 approved these changes

@Xiaoy312 Xiaoy312 Xiaoy312 approved these changes

@agneszitte agneszitte Awaiting requested review from agneszitte

@Marc-Antoine-Soucy Marc-Antoine-Soucy Awaiting requested review from Marc-Antoine-Soucy

Assignees

@nguyeenvy nguyeenvy

@Marc-Antoine-Soucy Marc-Antoine-Soucy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Chefs, TubePlayer] Need a Material style for the MediaPlayer
7 participants
@nguyeenvy @agneszitte @kazo0 @sasakrsmanovic @Xiaoy312 @pictos @Marc-Antoine-Soucy