Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ProgressBar-ProgressRing): lightweight styling for ProgressBar-Ring #1058

Merged
merged 2 commits into from
Sep 28, 2023
Merged

feat(ProgressBar-ProgressRing): lightweight styling for ProgressBar-Ring #1058

merged 2 commits into from
Sep 28, 2023

Conversation

rajamatt
Copy link
Contributor

@rajamatt rajamatt commented Jul 12, 2023 •
edited
Loading

GitHub Issue: closes https://github.com/unoplatform/uno.themes-private/issues/6

PR Type

What kind of change does this PR introduce?

  • Feature

Description

  • Continues lightweight styling for ProgressBar and ProgressRing controls.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Commits must be following the Conventional Commits specification
  • Tested UWP
  • Tested iOS
  • Tested Android
  • Tested WASM
  • Tested MacOS
  • Contains No breaking changes

    If the pull request contains breaking changes, commit message must contain a detailed description of the action to take for the consumer of this library. As explained by the Conventional Commits specification

@rajamatt rajamatt self-assigned this Jul 12, 2023
@rajamatt rajamatt requested review from Xiaoy312 and agneszitte July 12, 2023 19:35
@rajamatt rajamatt force-pushed the dev/mara/lightweight-styling-markup-progress branch from 9ac612f to a7663a6 Compare July 12, 2023 19:37
@rajamatt rajamatt force-pushed the dev/mara/lightweight-styling-markup-progress branch 3 times, most recently from 0996f9d to d966696 Compare July 24, 2023 15:35
@agneszitte agneszitte marked this pull request as draft August 11, 2023 16:10
@Arieldelossantos Arieldelossantos force-pushed the dev/mara/lightweight-styling-markup-progress branch 3 times, most recently from a096209 to 887e25c Compare September 20, 2023 15:22
@Arieldelossantos Arieldelossantos marked this pull request as ready for review September 20, 2023 15:23
@Marc-Antoine-Soucy Marc-Antoine-Soucy self-assigned this Sep 26, 2023
@kazo0 kazo0 force-pushed the dev/mara/lightweight-styling-markup-progress branch from 36c0a97 to 862ab0f Compare September 28, 2023 14:32
@kazo0 kazo0 enabled auto-merge (squash) September 28, 2023 15:05
@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1058.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit 70747a9 into master Sep 28, 2023
10 checks passed
@kazo0 kazo0 deleted the dev/mara/lightweight-styling-markup-progress branch September 28, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marc-Antoine-Soucy Marc-Antoine-Soucy Marc-Antoine-Soucy left review comments

@Arieldelossantos Arieldelossantos Arieldelossantos left review comments

@kazo0 kazo0 kazo0 approved these changes

@Xiaoy312 Xiaoy312 Awaiting requested review from Xiaoy312

@agneszitte agneszitte Awaiting requested review from agneszitte

Assignees

@rajamatt rajamatt

@Marc-Antoine-Soucy Marc-Antoine-Soucy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajamatt @kazo0 @agneszitte @Arieldelossantos @Marc-Antoine-Soucy