Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(markup): update c#markup #1232

Merged
merged 7 commits into from
Oct 26, 2023
Merged

chore(markup): update c#markup #1232

merged 7 commits into from
Oct 26, 2023

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented Oct 6, 2023 •
edited by kazo0
Loading

unoplatform/uno.themes-private#23

PR Type

What kind of change does this PR introduce?

  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)

Description

Updated markup with generated code

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

@Xiaoy312
Copy link
Contributor Author

Xiaoy312 commented Oct 6, 2023

saving top comment

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231006/markup-codegen-sorcery branch 2 times, most recently from 511a58d to 9f0bf51 Compare October 10, 2023 15:04
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1232.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231006/markup-codegen-sorcery branch from f81e05d to 6f4f462 Compare October 12, 2023 01:07
@unoplatform unoplatform deleted a comment from github-actions bot Oct 12, 2023
@unoplatform unoplatform deleted a comment from github-actions bot Oct 12, 2023
@unoplatform unoplatform deleted a comment from github-actions bot Oct 12, 2023
@unoplatform unoplatform deleted a comment from github-actions bot Oct 12, 2023
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1232.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231006/markup-codegen-sorcery branch from 6f4f462 to 277e28c Compare October 12, 2023 01:11
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1232.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231006/markup-codegen-sorcery branch from 277e28c to 8b02971 Compare October 12, 2023 01:18
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1232.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231006/markup-codegen-sorcery branch from 8b02971 to e652a7f Compare October 12, 2023 01:54
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1232.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1232.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 changed the title chore(markup)!: update c#markup chore(markup): update c#markup Oct 12, 2023
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231006/markup-codegen-sorcery branch from b54230b to 6559625 Compare October 12, 2023 18:11
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1232.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231006/markup-codegen-sorcery branch from 6559625 to d0d7fb8 Compare October 12, 2023 18:41
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1232.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 marked this pull request as ready for review October 12, 2023 18:53
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231006/markup-codegen-sorcery branch from d0d7fb8 to 99728d0 Compare October 12, 2023 20:18
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1232.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 requested review from kazo0 and agneszitte October 13, 2023 12:24
@Xiaoy312
Copy link
Contributor Author

Xiaoy312 commented Oct 16, 2023 •
edited
Loading

I will be closing this in favor of #1247.
However, in the meantime, I will leave this open until the comments here are addressed.
But please, leave new comment in the other thread: #1247

edit: change of plan, this will be merged first as an interim solution
until some of the codegen problems are solved be in (generator or xaml)...

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1232.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231006/markup-codegen-sorcery branch from 8b391fd to b05f9cd Compare October 19, 2023 15:14
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231006/markup-codegen-sorcery branch from b05f9cd to e41ff2e Compare October 19, 2023 15:16
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1232.eastus2.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1232.eastus2.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1232.eastus2.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1232.eastus2.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1232.eastus2.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1232.eastus2.azurestaticapps.net

@kazo0 kazo0 mentioned this pull request Oct 26, 2023
Open
@kazo0 kazo0 merged commit 6640857 into master Oct 26, 2023
10 checks passed
@kazo0 kazo0 deleted the dev/xygu/20231006/markup-codegen-sorcery branch October 26, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agneszitte agneszitte agneszitte left review comments

@kazo0 kazo0 kazo0 approved these changes

@dansiegel dansiegel dansiegel left review comments

@nickrandolph nickrandolph nickrandolph left review comments

Assignees

@kazo0 kazo0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Xiaoy312 @nickrandolph @dansiegel @kazo0 @agneszitte