feat: Themes markup generator #1239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Oct 10, 2023
| @@ -22,4 +22,8 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <Import Project="..\..\..\winappsdk-workaround.targets" /> | |||
| <Target Name="_UnoThemesRunGen" BeforeTargets="BeforeCompile"> | |||
| <MSBuild Projects="..\Uno.Themes.WinUI.Markup.Generator\Uno.Themes.WinUI.Markup.Generator.csproj" /> | |||
| <Exec Command='dotnet "..\Uno.Themes.WinUI.Markup.Generator\bin\Debug\net7.0\Uno.Themes.WinUI.Markup.Generator.dll"' /> | |||
There was a problem hiding this comment.
@Xiaoy312 I'm not going to push to the PR in case you already started continuing it locally, but Debug here likely needs to be replaced with $(Configuration), that is probably why the command execution fails in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: closes unoplatform/uno.themes-private#23
PR Type
What kind of change does this PR introduce?
Description
PR Checklist: n/a
Other information