Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add resource override path extensions #1243

Closed
wants to merge 2 commits into from

Conversation

Marc-Antoine-Soucy
Copy link
Contributor

@Marc-Antoine-Soucy Marc-Antoine-Soucy commented Oct 11, 2023

GitHub Issue: unoplatform/uno.toolkit.ui#870

PR Type

What kind of change does this PR introduce?

  • Feature

Description

Added an extension that allows a control to be linked to a resource dictionary so that you can apply lightweight styling more easily

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

image

Internal Issue (If applicable):

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1243.eastus2.azurestaticapps.net

@Marc-Antoine-Soucy Marc-Antoine-Soucy force-pushed the dev/maso/ressourceoverridepath branch from baedf77 to 39e4dcc Compare October 11, 2023 19:53
@Marc-Antoine-Soucy Marc-Antoine-Soucy force-pushed the dev/maso/ressourceoverridepath branch from 39e4dcc to 4058c39 Compare October 11, 2023 19:55
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1243.eastus2.azurestaticapps.net

@Marc-Antoine-Soucy Marc-Antoine-Soucy marked this pull request as ready for review October 11, 2023 19:59
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1243.eastus2.azurestaticapps.net

@Marc-Antoine-Soucy
Copy link
Contributor Author

Marc-Antoine-Soucy commented Oct 11, 2023

I'm not sure if additional documentation is needed? Maybe in lightweight styling? I added a sentence in the lightweight syling documentation, but I don't know if it's enough.

@Marc-Antoine-Soucy Marc-Antoine-Soucy force-pushed the dev/maso/ressourceoverridepath branch from 4058c39 to 6bd6fd1 Compare October 11, 2023 20:25
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1243.eastus2.azurestaticapps.net

Comment on lines +144 to +146
<CheckBox Content="Overridden checkbox style"
Style="{StaticResource MaterialCheckBoxStyle}"
um:ControlExtensions.ResourceOverridePath="ms-appx:///ControlResourcesOverride/CheckBox.xaml" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be used as more of a Setter attached property on a Style like here https://github.com/unoplatform/Uno.Themes/issues/1116#issuecomment-1759885473

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1243.eastus2.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants