fix: Use BodyLarge typography for TextBox Placholder #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport release/stable/5.0 |
✅ Backports have been created
|
carldebilly
approved these changes
Apr 10, 2024
agneszitte
reviewed
Apr 10, 2024
mergify bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
(cherry picked from commit fb3936c)
agneszitte
added a commit
that referenced
this pull request
Apr 11, 2024
….0/pr-1383 fix: Use BodyLarge typography for TextBox Placholder (backport #1383)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #1379
PR Type
What kind of change does this PR introduce?
The PlaceholderText should be using the BodyLarge typography values, same as the TextBox's Content element. For now, until #1014 is merged, we will also keep those typorgaphy values when the PlaceholderElement is translated to serve as the "header"/"label" of the TextBox and keep it scaled down to the same size as BodySmall