Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: refactor upgrade doc mentions #1392

Merged
merged 2 commits into from
Apr 16, 2024
Merged

docs: refactor upgrade doc mentions #1392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4b8178
docs: refactor upgrade doc mentions
kazo0 Apr 16, 2024
37f4df4
docs: pr comments
kazo0 Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions doc/material-migration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,20 @@
uid: Uno.Themes.Material.Migration
---

# Upgrading Uno.Material
# Upgrading Uno Material

## Upgrading to Uno Themes v5.0
## Upgrading to Uno Themes v5

Version 5.0.0 of Uno Themes introduces breaking changes to the library. Below are the changes that have been made:
The Uno Material v5 packages introduce a new dependency on the [Uno Themes](https://www.nuget.org/packages/Uno.Themes.WinUI) package. Uno Themes is the base library for all design system implementations going forward. As a result, the following changes have been made:

### Converters

All Converters were moved to the `Uno.Themes` library, and the new `namespace` is `Uno.Themes`.
All Converters were moved to the base `Uno.Themes` library, and the new `namespace` is `Uno.Themes`.

Before:

```xml
<Page xmlns:um="using:Uno.Material">

<Page.Resources>
<um:FromNullToValueConverter x:Key="NotNullVisibilityConverter">
</Page.Resources>
Expand All @@ -27,7 +26,6 @@ After:

```xml
<Page xmlns:ut="using:Uno.Themes">

<Page.Resources>
<ut:FromNullToValueConverter x:Key="NotNullVisibilityConverter">
</Page.Resources>
Expand Down
8 changes: 0 additions & 8 deletions doc/themes-control-extensions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,6 @@ uid: Uno.Themes.Control.Extensions

# Control Extensions

Starting on version 5.0.0 the `ControlExtensions` are available on the `Uno.Themes` namespace, so to use that in xaml you should add the following xmlns to your project:

`xmlns:ut="using:Uno.Themes"`

> [!INFO]
> For more information about see our [migration docs](material-migration.md).

agneszitte marked this conversation as resolved.
Show resolved Hide resolved
## Icon

This feature allows for the addition of icon on the supported controls. Those icons could be any of the [`IconElement`](https://learn.microsoft.com/windows/windows-app-sdk/api/winrt/microsoft.ui.xaml.controls.iconelement)s: `<BitmapIcon />`, `<FontIcon />`, `<PathIcon />`, or `<SymbolIcon />`.
Expand Down Expand Up @@ -114,4 +107,3 @@ The following control styles have support for elevation:
| Control | Supporting Styles |
|----------|-----------------------|
| `Button` | `ElevatedButtonStyle` |
|----------|-----------------------|
Loading