-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove platform specific, native commandBar styles #1421
Conversation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1421.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1421.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1421.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1421.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1421.eastus2.azurestaticapps.net |
@Kunal22shah we should edit the CommandBarSamplePage.xaml to no longer navigate to a separate stack of pages and just display a normal CommandBar directly in CommandBarSamplePage.xaml. Similar to how other sample pages are done like Button and CheckBox. You can see we currently direct people to click a Button to go to a new page where we have a CommandBar at the top and some text talking about the back button on the CommandBar. All of that isn't relevant anymore as the CommandBar is no longer being used for navigation as it was before: Let me know if you want to pair to work through as I know this one is a bit messy |
@kazo0 Done! |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1421.eastus2.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1421.eastus2.azurestaticapps.net |
src/samples/UWP/Uno.Themes.Samples.Shared/Content/Controls/CommandBarSamplePage.xaml
Outdated
Show resolved
Hide resolved
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1421.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1421.eastus2.azurestaticapps.net |
1be0ab1
to
7c181b8
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1421.eastus2.azurestaticapps.net |
@Mergifyio backport release/stable/5.1 |
✅ Backports have been created
|
(cherry picked from commit 9b440f0)
…1421) (#1426) Co-authored-by: Kunal Shah <[email protected]>
GitHub Issue:
closes #1418
closes #1425
PR Type
What kind of change does this PR introduce?
Description
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):