Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: MaterialOutlinedTextBoxStyle layout #1494

Merged
merged 3 commits into from
Oct 28, 2024
Merged

fix: MaterialOutlinedTextBoxStyle layout #1494

merged 3 commits into from
Oct 28, 2024

Conversation

Xiaoy312
Copy link
Contributor

GitHub Issue:
fix #1469 (comment)
partially fixed #1487 for Outlined style

PR Type

What kind of change does this PR introduce?

  • Bugfix

Description

adjust MaterialOutlinedTextBoxStyle template to respect MinHeight
fix MaterialOutlinedTextBoxStyle header position in multiline mode

PR Checklist

Please check if your PR fulfills the following requirements:

@Xiaoy312 Xiaoy312 changed the title chore: fix a TreeGraph crash fix: MaterialOutlinedTextBoxStyle layout Oct 25, 2024
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1494.eastus2.azurestaticapps.net

@agneszitte
Copy link
Contributor

@Xiaoy312 I think this PR also fixes https://github.com/unoplatform/uno.chefs/issues/710 for WASM no ?

@Xiaoy312
Copy link
Contributor Author

Xiaoy312 commented Oct 25, 2024 •
edited
Loading

@Xiaoy312 I think this PR also fixes unoplatform/uno.chefs#710 for WASM no ?

no this doesnt fix passwordbox, we didnt touch that file, but the problem is of same nature

@agneszitte
Copy link
Contributor

agneszitte commented Oct 25, 2024 •
edited
Loading

@Xiaoy312 I think this PR also fixes unoplatform/uno.chefs#710 for WASM no ?

no this doesnt fix passwordbox, we didnt touch that file, but the problem is of same nature

Oh yeah sorry, Password is separated.

But it was related to TextBox also @Xiaoy312 if I am not mistaken, see https://github.com/unoplatform/uno.studio/issues/537#issuecomment-2102665064
I will let you quickly double check details left in regards to studio please

@Xiaoy312 Xiaoy312 enabled auto-merge October 28, 2024 15:35
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1494.eastus2.azurestaticapps.net

@Xiaoy312 @agneszitte
chore: fix doc wording
857e0fe 
Co-authored-by: Agnès ZITTE <[email protected]>
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20241024/outline-textbox-template-layout branch from e657936 to 857e0fe Compare October 28, 2024 16:20
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1494.eastus2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1494.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 merged commit b7fe90b into master Oct 28, 2024
20 checks passed
@Xiaoy312 Xiaoy312 deleted the dev/xygu/20241024/outline-textbox-template-layout branch October 28, 2024 16:40
@Xiaoy312 Xiaoy312 mentioned this pull request Nov 1, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agneszitte agneszitte agneszitte approved these changes

@kazo0 kazo0 Awaiting requested review from kazo0

@Kunal22shah Kunal22shah Awaiting requested review from Kunal22shah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Xiaoy312 @agneszitte