Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cors bypass for RSS parser sample #62

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

XiaotianNetlift
Copy link

Issue: #61

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Rss Parser sample can't load feed because of CORS:

Access to fetch at 'https://visualstudiomagazine.com/rss-feeds/news.aspx' from origin 'http://localhost:49996' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

What is the new behavior?

cors-anywhere is used to bypass this.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

https://github.com/Rob--W/cors-anywhere

@XiaotianNetlift XiaotianNetlift force-pushed the dev/xygu/162211/cors-bypass branch from 9c5b116 to 30068cc Compare September 25, 2019 21:10
@XiaotianNetlift XiaotianNetlift merged commit 21cab7f into uno Sep 30, 2019
@XiaotianNetlift XiaotianNetlift deleted the dev/xygu/162211/cors-bypass branch September 30, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants