Skip to content

Conversation

rajamatt
Copy link
Contributor

GitHub Issue (If applicable): for https://github.com/unoplatform/uno-private/issues/1513

PR Type

What kind of change does this PR introduce?

Exposing the MachineId of the Telemetry client so we can track it externally in apps.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@rajamatt rajamatt requested a review from jeromelaban October 10, 2025 18:12
@rajamatt
Copy link
Contributor Author

@jeromelaban is there a better way to expose or get the MachineId? This is for work in https://github.com/unoplatform/uno-private/issues/1513 (where we would identify the user based on their MachineId)

@rajamatt rajamatt requested a review from carldebilly October 14, 2025 18:36
@jeromelaban jeromelaban requested a review from Copilot October 16, 2025 20:57
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR exposes the MachineId from the Telemetry client to enable external tracking in applications. The change adds a new asynchronous method to retrieve the machine ID that was previously only used internally.

  • Adds a GetMachineIdAsync method to both the interface and implementation
  • Uses a TaskCompletionSource to handle the asynchronous nature of machine ID initialization

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/Uno.DevTools.Telemetry/ITelemetry.cs Adds GetMachineIdAsync method signature to the interface
src/Uno.DevTools.Telemetry/Telemetry.cs Implements GetMachineIdAsync with TaskCompletionSource for async coordination

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rajamatt rajamatt merged commit 31ac497 into main Oct 16, 2025
5 checks passed
Copy link

welcome bot commented Oct 16, 2025

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

@rajamatt rajamatt deleted the dev/mara/public-machine-id branch October 16, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants