fix: remove the RequiredAtrribute and change the dependency chain

UnoGeneratePackageAppxManifest doesn't exist on other targets, so we changed the UnoGeneratePackageAppxManifest to depend on _GenerateWindowUnoIconExtension target instead
unoplatform · Jan 29, 2024 · 6976558 · 6976558
1 parent d5d4e15
commit 6976558
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/src/.nuspec/Uno.Resizetizer.targets b/src/.nuspec/Uno.Resizetizer.targets
@@ -509,7 +509,6 @@
 	<Target Name="_GenerateWindowUnoIconExtension"
 			Condition="'$(_UnoResizetizerIsCompatibleApp)' == 'True'"
 			BeforeTargets="Build;CoreCompile;XamlPreCompile"
-            DependsOnTargets="UnoGeneratePackageAppxManifest"
 			Inputs="@(UnoIcon)"
 			Outputs="@(_WindowIconExtension)">
 		<WindowIconGeneratorTask_v0

diff --git a/src/.nuspec/Uno.Resizetizer.windows.skia.targets b/src/.nuspec/Uno.Resizetizer.windows.skia.targets
@@ -52,10 +52,11 @@
 			BeforeTargets="_ValidatePresenceOfAppxManifestItems"
 			DependsOnTargets="UnoGeneratePackageAppxManifest"
 			Condition="'$(_UnoResizetizerIsWindowsAppSdk)' == 'True' Or '$(_UnoResizetizerIsSkiaApp)' == 'True'"/>
+
 	<Target Name="UnoGeneratePackageAppxManifest"
 			Condition="('$(_UnoResizetizerIsWindowsAppSdk)' == 'True' Or '$(_UnoResizetizerIsSkiaApp)' == 'True') And ('@(AppxManifest)@(_UnoAppxManifest)' !='' Or @(_SkiaManifest) != '')"
 			DependsOnTargets="$(UnoGeneratePackageAppxManifestDependsOnTargets)"
-			BeforeTargets="$(UnoGeneratePackageAppxManifestBeforeTargets)"
+			BeforeTargets="$(UnoGeneratePackageAppxManifestBeforeTargets);_GenerateWindowUnoIconExtension"
 			Inputs="$(MSBuildThisFileFullPath);$(_UnoResizetizerTaskAssemblyName);$(_UnoResizetizerInputsFile);$(_UnoSplashInputsFile);@(AppxManifest);@(_UnoAppxManifest)"
 			Outputs="$(_UnoManifestStampFile);$(_UnoIntermediateManifest)Package.appxmanifest">
 

diff --git a/src/Resizetizer/src/WindowIconGeneratorTask.cs b/src/Resizetizer/src/WindowIconGeneratorTask.cs
@@ -14,7 +14,6 @@ public class WindowIconGeneratorTask_V0 : Task
 	[Required]
 	public string IntermediateOutputDirectory { get; set; }
 
-	[Required]
 	public string WindowTitle { get; set; }
 
 	[Output]