Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the correct background color on SplashScreen's background #162

Merged
merged 7 commits into from
Sep 21, 2023
Merged

Set the correct background color on SplashScreen's background #162

merged 7 commits into from
Sep 21, 2023

Conversation

pictos
Copy link
Contributor

@pictos pictos commented Jul 31, 2023 •
edited
Loading

Fixes: #156

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

The icon background wasn't tinted with the backgroundColor set on UnoSplashScreen.

What is the new behavior?

The icon's background is tinted with the color set on UnoSplashScreen.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@pictos pictos requested a review from nickrandolph July 31, 2023 23:34
@pictos pictos force-pushed the pj/fix-splash-background-color branch from 4e9a505 to fcc1628 Compare August 4, 2023 18:14
nickrandolph
nickrandolph requested changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@nickrandolph nickrandolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we confirmed these changes don't break if there's no uno splash screen defined?

@pictos pictos requested a review from nickrandolph August 14, 2023 18:09
@pictos pictos requested a review from dansiegel August 17, 2023 16:41
@dansiegel dansiegel enabled auto-merge August 18, 2023 13:45
@pictos
Copy link
Contributor Author

pictos commented Aug 21, 2023

Have we confirmed these changes don't break if there's no uno splash screen defined?

@nickrandolph , yes

@pictos pictos requested a review from nickrandolph September 11, 2023 22:00
@nickrandolph nickrandolph force-pushed the pj/fix-splash-background-color branch from b2f273d to d8e9f39 Compare September 21, 2023 13:28
@dansiegel dansiegel merged commit 7a24b3d into main Sep 21, 2023
@dansiegel dansiegel deleted the pj/fix-splash-background-color branch September 21, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickrandolph nickrandolph nickrandolph approved these changes

@dansiegel dansiegel dansiegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[WASM] When splash screen background color is changed the logo image background stays the old color
3 participants
@pictos @nickrandolph @dansiegel