Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "♻️ bump packages versions" #176

Closed

Conversation

Youssef1313
Copy link
Member

Reverts #173

The update is causing issues: unoplatform/uno#13878

@Youssef1313
Copy link
Member Author

@mergify backport release/stable/1.1

@mergify
Copy link

mergify bot commented Oct 3, 2023

backport release/stable/1.1

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission>=write

@Youssef1313 Youssef1313 force-pushed the revert-173-pj/bump-packages branch from 2588913 to 9bc3dd7 Compare October 3, 2023 13:53
@Youssef1313
Copy link
Member Author

@pictos @jeromelaban Could you review and backport please?

@pictos
Copy link
Contributor

pictos commented Oct 3, 2023

@Youssef1313 let's wait to see what's the issue caused on the Uno repo first.

We have to update the packages anyway, due to a vulnerability on SkiaSharp, so just reverting will not be the correct fix.

@Youssef1313
Copy link
Member Author

@pictos I don't think the issue is Uno-specific. The SkiaSharp version used by Uno package is unrelated to the build failure happening. I'd guess the correct course of action is to add a binding redirect, but this is meant as a fast fix for the regression until the proper fix is done.

@pictos
Copy link
Contributor

pictos commented Oct 3, 2023

@Youssef1313 I bumped the skia version to the because of a vulnerability found on previous versions. Because of that I don't think downgrade is the correct fix. Let's await the resolution on the Uno PR and came with a plan

@Youssef1313 Youssef1313 deleted the revert-173-pj/bump-packages branch October 12, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants