♻️Bump versions to avoid method missmatch #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Is there a way to validate that this doesn't regress? |
|
@Youssef1313 I tested this version locally on an App that was reproducing the issue, and it worked. So we should be able to go |
I meant an additional CI validation that would fail before this PR and pass with this PR. It's a nice to have, but getting this merged soon is more important. |
|
Let's see if this change helps, as it seems to be a mismatch between Svg.Skia and SkiaSharp it self. I'm also surprised the original issue is not picked up by this repo's CI tests. @pictos are we running a sample that uses the SVG conversions parts in the CI? |
jeromelaban
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no issue opened for this one, but some other Uno apps are failing on Resizetizer, so bumping more packages should fix it. Some of these packages are released this week, so that could help.