[🔥HotFix] Fixed the git hash used #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pictos
force-pushed
the
pj/fix-id-collision
branch
from
ac757bd to
373806a
Compare
jeromelaban
approved these changes
Oct 19, 2023
|
🚀 |
pictos
force-pushed
the
pj/fix-id-collision
branch
from
9ba1d2e to
4b70248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, you may notice that we decore some
MSBuildtasks with thev_0suffix, this is intended to be changed, during the build, to the commit hash, in order to avoid confusion with different Uno.Resizetizer packages in the nuget cache. This appears in the first place when you have theUno.Resizetizer 1.2.0-dev.39and update to1.2.0-dev.76, will break the build, because there's a breaking change on the task, and the compiler will try to use the old version.The issue was that our CI was using the wrong variable to replace the
v_0and now using the correct one should fix it and make the world happy again. The good news is the git keeps generating different hashes for commits, so no apocalypse so far.