Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the appxmanifest generation #201

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

pictos
Copy link
Contributor

@pictos pictos commented Nov 24, 2023

Fixes: #199

From the original implementation, Skia Targets generates just one icon image, in terms of usability that was enough, but since Skia Targets uses the appxmanifest this PR updates those targets to generate the same assets as winUI and match with the generated appxmanifest.

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@pictos pictos self-assigned this Nov 24, 2023
@pictos pictos requested a review from jeromelaban November 24, 2023 22:31
@nickrandolph nickrandolph merged commit 7ad1199 into main Dec 1, 2023
6 checks passed
@nickrandolph nickrandolph deleted the pj/fix-appxmanifest-generation-on-skia branch December 1, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to find icon file iconStoreLogo specified in the appxmanifest
3 participants