Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window Appicon for Windows Unpackage #204

Merged
merged 8 commits into from
Dec 1, 2023

Conversation

pictos
Copy link
Contributor

@pictos pictos commented Nov 27, 2023

Fixes: #203

When running Windows Unpackage, it doesn't copy the .ico to the output folder by default (bin folder), so I'm adding it on Resizetizer task.

I also updated the Windows head project, to be able to run the Unpackage version

PR Type

  • Bugfix
    What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

When running Windows unpackage it not get copied to the output directory automatically, so doing it by our selfs
@pictos pictos requested a review from nickrandolph November 27, 2023 20:37
@pictos pictos force-pushed the pj/windows-unpackage-appicon-issue branch from 2ade4cc to 5a88b12 Compare November 28, 2023 14:24
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ pictos
❌ Pedro Henrique de Souza Jesus


Pedro Henrique de Souza Jesus seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nickrandolph nickrandolph merged commit 6461423 into main Dec 1, 2023
5 of 6 checks passed
@nickrandolph nickrandolph deleted the pj/windows-unpackage-appicon-issue branch December 1, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App icon doesn't show up when build for Windows unpackaged
3 participants