Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set AppWindow.Title to DisplayName #209

Closed

Conversation

lukeblevins
Copy link
Contributor

Fixes: #208

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Context:
On Windows targets, AppWindow currently lacks a default value for its Title property.

In our task for generating window icon, we form the code to retrieve an AppWindow from the XAML Window, using it to conveniently set the generated ico file.

What is the new behavior?

Upon retrieval of AppWindow, set AppWindow.Title to be the app's DisplayName. This value is obtained from the XAML Window instance which has a pre-defined Title property. (defaulting to DisplayName)

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

if (appWindow != null)
{{
appWindow.SetIcon(""{iconName}.ico"");
appWindow.Title = AppInfo.Current.DisplayInfo.DisplayName;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code doesn't work, from the top of my head, this looks like a Microsoft.Maui.Essentials call, so it will work just if we add a reference to that package, with I believe we don't want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set window title on Windows for running unpackaged
3 participants