fix: Set AppWindow.Title to DisplayName #209
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #208
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Context:
On Windows targets,
AppWindow
currently lacks a default value for itsTitle
property.In our task for generating window icon, we form the code to retrieve an
AppWindow
from the XAMLWindow
, using it to conveniently set the generatedico
file.What is the new behavior?
Upon retrieval of
AppWindow
, set AppWindow.Title to be the app'sDisplayName
. This value is obtained from the XAMLWindow
instance which has a pre-definedTitle
property. (defaulting toDisplayName
)PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):