Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UnoImage from Content and AndroidAsset items #219

Merged
merged 10 commits into from
Mar 27, 2024

Conversation

pedrojesus-work
Copy link
Contributor

@pedrojesus-work pedrojesus-work commented Mar 21, 2024

Fixes: #218

This will work when using dotnet build from the command line, but when build using VS the svg is still there, not sure why isn't excluded

It just works (:

PR Type

  • Bugfix
    What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

as you can see there's no more svg package there
image

Internal Issue (If applicable):

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2024

CLA assistant check
All committers have signed the CLA.

@unoplatform unoplatform deleted a comment from pictos Mar 22, 2024
src/.nuspec/Uno.Resizetizer.targets Outdated Show resolved Hide resolved
src/.nuspec/Uno.Resizetizer.targets Outdated Show resolved Hide resolved
src/Resizetizer/src/CleanupAssetsTask.cs Show resolved Hide resolved
src/Resizetizer/src/CleanupAssetsTask.cs Outdated Show resolved Hide resolved
src/Resizetizer/src/RemoveSvgFromContentTask.cs Outdated Show resolved Hide resolved
src/Resizetizer/src/RemoveSvgFromContentTask.cs Outdated Show resolved Hide resolved
src/Resizetizer/src/RemoveSvgFromContentTask.cs Outdated Show resolved Hide resolved
@pedrojesus-work pedrojesus-work merged commit 4c4867a into main Mar 27, 2024
6 checks passed
@pedrojesus-work pedrojesus-work deleted the pj/svg-android-issue branch March 27, 2024 18:36
Copy link

welcome bot commented Mar 27, 2024

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

@pedrojesus-work pedrojesus-work mentioned this pull request Apr 30, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG | Android] svg files used on UnoImages are added to the app
6 participants