.Shared instead of .Base
#221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinZikmund
force-pushed
the
MartinZikmund-patch-1
branch
from
83f7256 to
b3ddb4a
Compare
dansiegel
reviewed
Mar 24, 2024
| @@ -98,7 +98,7 @@ During the creation of your `svg` file, please remember to make the `ViewBox` bi | |||
| # [**Class Library Based Solution**](#tab/classlib) | |||
|
|
|||
| * Create an `Icons` folder inside the Base project, and add the files related to the app icon there. | |||
| * Now open the `base.props` file, inside the `MyApp.Base` folder project and add the following block: | |||
| * Now open the `base.props` file, inside the `MyApp.Shared` project and add the following block: | |||
There was a problem hiding this comment.
should we perhaps make reference to both as it really depends on which version of the template was used to create their project. They may or may not have the MyApp.Shared project and it may instead be MyApp.Base... also should this be updated for our new project format as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):