Update Publisher #281
Merged
Update Publisher #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
TargetDeviceFamilies are not updated with the TargetPlatformVersion and the TargetPlatformMinVersion provided by MSBuild. We do not have a property that handles the Identity Publisher
What is the new behavior?
We now will set the Publisher Display Name and the Identity Publisher values in the AppxManifest via the new ApplicationPublisher MSBuild property if it exists. If it does not exist it will fall back to the Authors property which falls back to the Application Title and ultimately the Assembly Name. This ensures there is always a value for these even if the properties were not directly supplied.
This will now check for any TargetDeviceFamily elements within the Dependencies. If none exists it will add one for
Windows.UniversalandWindows.Desktopwhich are the defaults in the WinUI and the Uno Templates. If theMinVersionorMaxVersionTestedattributes are either not set or have a default value of0.0.0.0it will use theTargetPlatformVersionandTargetPlatormMinVersionto set these attributes.