Delete Task does not delete tasks

[NVLudwig]

Current behavior

Pressing the delete task, gives a pressed state but nothing after, and no change is applied to the list

Expected behavior

Task should be deleted and list updated. If in Task details at the time of deleting it user should navigate back to previous view (false in Desktop mode, If details is in a pane, pane should close). (Bonus points for displaying a Toast reading "Task Deleted"

How to reproduce it (as minimally and precisely as possible)

Go to any task detail and presse the delete button at the bottom of the screen

Environment

Mac
OS
Chrome Version 100.0.4896.75 (Official Build) (x86_64)

Private window

Nuget Package:

Package Version(s):

Affected platform(s):

• iOS
• Android
• WebAssembly
• WebAssembly renders for Xamarin.Forms
• Windows
• Build tasks

Visual Studio:

• 2017 (version: )
• 2019 (version: )
• for Mac (version: )

Relevant plugins:

• Resharper (version: )

Anything else we need to know?

[agneszitte]

@NVLudwig deleting the task was fixed with the changes in the PR I made #188
The list is updated and on mobile or narrow desktop version it navigates back.

Issues left to be fixed:

• In Desktop mode, If details are in a pane, the pane should close
• Bonus points for displaying a Toast reading "Task Deleted" (@nickrandolph what do you think regarding this one, and also @NVLudwig there is no toast on the Windows To-Do app no ?)

[nickrandolph]

@agneszitte-nventive we don't currently have support in navigation for displaying a toast (but it is a good idea).

[agneszitte]

@NVLudwig / @nickrandolph I think we can keep this idea aside for the toast for now. We need to finish/fix/stabilize some other important parts of the app. We can revisit the idea later on when we have time for improving the app. Let me know if it's okay with you

[NVLudwig]

Yup it's ok,
We don't support toasts so it would have been a nice idea but we aren't in a place to do it.

I still can't delete tasks today...

[agneszitte]

Thanks @NVLudwig for the feedback !
Looking into it for deleting a task as another issue was introduced lately (same as trying to sign out and deleting a list)

[nickrandolph]

This PR should address the issue with deleting tasks (and other places message dialog is used): #268

[agneszitte]

Deleting task is fixed with #268
The last thing to fix @nickrandolph is to close the right pane when the task is deleted

[NVLudwig]

...it deletes every task in the list now...

[agneszitte]

Ok I will double-check that @NVLudwig (cc @nickrandolph)

[agneszitte]

I'm not able to reproduce @NVLudwig issue on my side even with the stating link.
Even the Microsoft ToDo App is correctly updated without deleting the entire list.
Waiting on @NVLudwig to test on another browser to see if he still can reproduce the issue on his side.

[agneszitte]

@nickrandolph heads up that I did some tests and also asked other devs to test on their side and I cannot reproduce @NVLudwig issue (deletes every task in the list at the same time). So I did some tests with @NVLudwig and normally it's a cache issue on his side and he wasn't using the latest version.

@nickrandolph the only last thing to fix for this issue is the fact that the task details tab should close after deleting the task. So I will assign this issue to you also since you will work on that.

[nickrandolph]

@agneszitte-nventive I'm closing this issue as the remaining work is tracked in #280