fix: cutted text with content only long text #1009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xiaoy312
approved these changes
Jan 19, 2024
kazo0
reviewed
Jan 24, 2024
| @@ -989,7 +991,7 @@ | |||
| <VisualState x:Name="ContentOnly"> | |||
| <VisualState.Setters> | |||
| <Setter Target="IconBox.Visibility" Value="Collapsed" /> | |||
| <Setter Target="ContentPresenter.Margin" Value="12,0" /> | |||
| <Setter Target="ContentPresenter.Margin" Value="{ThemeResource TopTabBarItemContentOnlyMargin}" /> | |||
There was a problem hiding this comment.
I like that we are moving this to a resource but it won't cover all cases. If you have a large enough string, it'll still clip. So we should probably add a TextTrimming="CharacterEllipsis" or something to the contentpresenter, if that's available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
with content only tabBar item, if the text is too long, it is cutted off.
What is the new behavior?
support larger text with may tabs created.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):
https://github.com/unoplatform/uno.chefs/issues/937