Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix maxwidth=nan throw #1010

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented Jan 19, 2024

GitHub Issue (If applicable): n/a

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

drawerflyout are now throwing: Property 'MaxWidth' cannot be set to NaN. It must not be NaN or negative.

What is the new behavior?

not throwing anymore

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

the error were introduced by: unoplatform/uno#15050
but it is not supposed to throw (as evidenced by windows)
although, microsoft does suggested that: "This value can be any value equal to or greater than 0. PositiveInfinity is also valid."
on windows, setter with value of NaN or PositiveInfinity both results in +inf.
---
note that the setters are needed to override the (758x456) values from the default style

@Xiaoy312 Xiaoy312 requested review from Youssef1313 and kazo0 January 19, 2024 17:29
@Xiaoy312
Copy link
Contributor Author

image

@Xiaoy312 Xiaoy312 enabled auto-merge January 19, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants