fix: Fix WaitForIdle to really wait for "Idle" #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinZikmund
approved these changes
Dec 20, 2023
|
@dr1rrb @jeromelaban This is a blocker for lifecycle. It seems it's the root cause of HotReload failure |
Youssef1313
force-pushed
the
wait-for-idle
branch
3 times, most recently
from
256db03 to
c59ce5a
Compare
Youssef1313
force-pushed
the
wait-for-idle
branch
3 times, most recently
from
e280712 to
69eff0c
Compare
Youssef1313
force-pushed
the
wait-for-idle
branch
from
69eff0c to
a9bfb90
Compare
dr1rrb
approved these changes
Dec 20, 2023
|
Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):