fix: Make sure to generate OriginalSourceLocation property on DataTemplates #19389
+378
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rty information for empty elements (usually DataTemplates) when Hot Reload (and Hot Design) is used.
github-actions
bot
added
the
area/code-generation
jeromelaban
approved these changes
Jan 30, 2025
carldebilly
force-pushed
the
dev/cdb/hr-OriginalSourceLocation
branch
2 times, most recently
from
10c7b6a to
4d9d40e
Compare
carldebilly
force-pushed
the
dev/cdb/hr-OriginalSourceLocation
branch
from
4d9d40e to
1c45c37
Compare
dr1rrb
approved these changes
Jan 30, 2025
...urceGenerators/Uno.UI.SourceGenerators.Tests/XamlCodeGeneratorTests/Verifiers/CSGenerator.cs
Show resolved
Hide resolved
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19389/index.html |
|
The build 153714 found UI Test snapshots differences: Details
|
|
@Mergifyio backport release/stable/5.6 |
✅ Backports have been created
|
jeromelaban
added a commit
that referenced
this pull request
Jan 31, 2025
…5.6/pr-19389 fix: Make sure to generate OriginalSourceLocation property on DataTemplates (backport #19389)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): https://github.com/unoplatform/uno.hotdesign/issues/2980#issuecomment-2622762701 (related, not closing it)
Bugfix
What is the current behavior?
Right now, when generating the code for an empty
<DataTemplate />, there's is noOriginalSourceLocationproperty attached to it, because it's empty.Hot Design rely on this, but the location in the sources is lost when root element of the template is removed, causing problems.
What is the new behavior?
When Hot Reload (so Hot Design) is used, the property is always set, even if there's no children.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.