fix: Make sure to generate OriginalSourceLocation property on DataTemplates (backport #19389) #19400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
6 tasks
github-actions
bot
added
the
area/code-generation
ajpinedam
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): https://github.com/unoplatform/uno.hotdesign/issues/2980#issuecomment-2622762701 (related, not closing it)
Bugfix
What is the current behavior?
Right now, when generating the code for an empty
<DataTemplate />, there's is noOriginalSourceLocationproperty attached to it, because it's empty.Hot Design rely on this, but the location in the sources is lost when root element of the template is removed, causing problems.
What is the new behavior?
When Hot Reload (so Hot Design) is used, the property is always set, even if there's no children.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.This is an automatic backport of pull request #19389 done by [Mergify](https://mergify.com).