Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Restore listview based tests for iOS #17266

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -385,9 +385,6 @@ public void TreeViewItemTemplateTest()
[TestMethod]
#if __MACOS__
[Ignore("Currently fails on macOS, part of #9282 epic")]
#endif
#if __IOS__
[Ignore("Fails on iOS 17 https://github.com/unoplatform/uno/issues/17102")]
#endif
public async Task ValidateTreeViewItemSourceChangeUpdatesChevronOpacity()
{
Expand Down Expand Up @@ -530,9 +527,6 @@ public void TreeViewNodeStringableTest()
[TestMethod]
#if __MACOS__
[Ignore("Currently fails on macOS, part of #9282 epic")]
#endif
#if __IOS__
[Ignore("Fails on iOS 17 https://github.com/unoplatform/uno/issues/17102")]
#endif
public async Task TreeViewPendingSelectedNodesTest()
{
Expand Down Expand Up @@ -579,9 +573,6 @@ await RunOnUIThread.ExecuteAsync(() =>
[TestMethod]
#if __MACOS__
[Ignore("Currently fails on macOS, part of #9282 epic")]
#endif
#if __IOS__
[Ignore("Fails on iOS 17 https://github.com/unoplatform/uno/issues/17102")]
#endif
public async Task TreeViewSelectionChangedSingleMode()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -341,9 +341,6 @@ public async Task When_Setting_SelectedItem_DoesNotTakeEffect()
Assert.AreEqual(-1, listControl.SelectedIndex);
}

#if __IOS__
[Ignore("Fails on iOS 17 https://github.com/unoplatform/uno/issues/17102")]
#endif
[TestMethod]
public async Task When_Setting_SelectedItem_TakesEffect()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@

namespace Uno.UI.RuntimeTests.Tests.Windows_UI_Xaml_Controls
{
#if __IOS__
[Ignore("Disable all listview tests until crash is resolved https://github.com/unoplatform/uno/issues/17101")]
#endif
public partial class Given_ListViewBase // resources
{
private ResourceDictionary _testsResources;
Expand Down
Loading