-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(styles): adjust main.css
to fix 'SIGN IN' visibility on 13-inch screens
#19551
base: master
Are you sure you want to change the base?
fix(styles): adjust main.css
to fix 'SIGN IN' visibility on 13-inch screens
#19551
Conversation
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19551/index.html |
main.css
to fix 'SIGN IN' visibility on 13-inch…main.css
to fix 'SIGN IN' visibility on 13-inch screens
@@ -3,6 +3,10 @@ | |||
@media(max-width: 1179.98px){.hidden-sm{display:none !important}}@media(max-width: 1179.98px){.article>.col-md-8{width:100%}}.sideaffix{overflow:auto;padding-top:36px;margin-top:0}.sideaffix .affix ul>li.active>ul,.sideaffix .affix ul>li.active>a:before,.sideaffix .affix ul>li>a:hover:before{white-space:normal}.sideaffix>div.contribution>ul>li>a.contribution-link{font-family:"Open Sans";font-style:normal;font-weight:400;font-size:14px;line-height:20px;letter-spacing:.25px}.sideaffix #affix{font-size:16px;font-weight:600;line-height:1.5;height:auto}.sideaffix #affix a{color:#333;font-size:14px;line-height:20px;font-weight:400;letter-spacing:.25px}.sideaffix #affix ul>li.active>a{font-weight:bold}.sideaffix #affix ul>li.active>a:before{color:#333}.sideaffix #affix ul>li.active>a ul>li.active>a{font-weight:bold}.sideaffix #affix ul>li.active>a ul>li.active>a:before{color:#333}.sideaffix #affix ul ul>li>a:before{top:2px}.sideaffix #affix li:last-child{padding-bottom:16px;margin-bottom:0}.sideaffix #affix .title{text-transform:uppercase;font-size:12px;font-style:normal;font-weight:500;line-height:16px;letter-spacing:1.5px}.sideaffix #affix .level1::before{width:75%}.sideaffix #affix .level1::after{width:75%}.sideaffix h5{letter-spacing:1.5px;font-size:12px;line-height:16px;text-transform:uppercase;color:#9d9d9d} | |||
.alert{background-color:rgba(0,0,0,0);border-color:#f1f1f1;color:#333;padding:16px 16px;transition:transform .2s}.alert-hover:hover{transform:scale(1.05);border-color:#159bff;box-shadow:0 5px 10px 0 rgba(0,0,0,.2)}.alert-hover:hover h4{color:#159bff} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcoscodnet the CLI will need to be signed for the person who committed for the PR: #19551 (comment)
Also, I see two different usernames here, one for opening the PR itself (marcoscodnet) and one for the commit (mpinia76):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @marcoscodnet, for your commits in this PR that were pushed using mpinia76
instead of using your GitHub user marcoscodnet
, here are some additional details to help you:
1️⃣ Check Your Git Configuration
In PhpStorm, go to File → Settings → Version Control → Git, and ensure the correct Git user is set.
Then, verify your Git user settings with:
git config --global user.name
git config --global user.email
If it shows mpinia76
, update it (globally) with:
git config --global user.name "marcoscodnet"
git config --global user.email "[email protected]"
OR
If you want to update it for this repository only, update it with:
git config --local user.name "marcoscodnet"
git config --local user.email "[email protected]"
2️⃣ Clear Cached Credentials (if needed)
If PhpStorm is using an old login, reset it:
git credential reject https://github.com
Or, on Windows, remove outdated credentials via Credential Manager.
3️⃣ Update Your Commit Author
To fix the commits in this PR:
git rebase -i HEAD~X # Replace X with the number of commits to update
git commit --amend --author="marcoscodnet <[email protected]>"
git push --force-with-lease
4️⃣ Re-sign the CLA
Once your commits reflect the correct marcoscodnet
GitHub user, re-check the CLA status and sign it again as needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcoscodnet there is still a commit with mpinia76 as the author:
You will need to re-adjust the first commit with the correct username or replace all previous 3 commits by one commit with the correct username (with force push).
sorry, but mpinia76 is also me, I don't know why when I push from phpstorm it takes my other user (I have several), even though I am logged in with marcoscodnet |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19551/index.html |
@marcoscodnet I have left more info here. |
14f031e
to
56ff9b9
Compare
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19551/index.html |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19551/index.html |
|
||
// Media queries for font size and padding adjustments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcoscodnet Could we align the banner buttons with the Uno Platform website for consistency? This includes matching the style, font, and size adjustments based on the same breakpoints (as right now it is really different).
(As we can switch from one site to another and it should match the same visually if possible)
Uno.Platform.Banner.mp4
I get as close as possible to the menu of pltform.uno, but I can't make it identical. Please verify. |
GitHub Issue (If applicable): closes https://github.com/unoplatform/uno-website/issues/315
PR Type
What is the current behavior?
The 'SIGN IN' option is not fully visible in full-screen mode on a 13-inch screen.
What is the new behavior?
Fixed the issue by modifying main.css, ensuring that the 'SIGN IN' option is now fully visible.
PR Checklist
Other information
N/A