YearWeekIso was modified #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarfgq
requested changes
Jan 30, 2025
src/dateRange.ts
Outdated
| const startDate = new Date(actualYear, 0, 1 + (actualWeek - 1) * 7); | ||
| const endDate = new Date(actualYear, 0, 7 + (actualWeek - 1) * 7); | ||
| const startDate = getDateOfISOWeek(actualWeek, actualYear); | ||
| const endDate = new Date(startDate); |
There was a problem hiding this comment.
I have changed the logic for better understanding
src/weekUtils.ts
Outdated
| @@ -21,3 +21,15 @@ export const getIsoYearByDate = (date: Date): number => { | |||
| }; | |||
|
|
|||
| export const getIsoYear = (): number => getIsoYearByDate(new Date()); | |||
|
|
|||
| export const getDateOfISOWeek = (week: number, year: number): Date => { | |||
| const simple = new Date(year, 0, 1 + (week - 1) * 7); | |||
There was a problem hiding this comment.
From reading the code we cannot tell what "simple" could be. Try to make it understandable in order to make the code easier to improve in the future.
|
@oscarfgq you guys should consider to delete this logic and use date fns instead. For example: https://date-fns.org/v4.1.0/docs/startOfISOWeek |
|
Absolutely 👍🏼 |
|
geoperez
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.