Skip to content

Commit

Permalink
chore: fix error, minor update
Browse files Browse the repository at this point in the history
  • Loading branch information
zernonia committed Sep 18, 2024
1 parent 3217a00 commit f574025
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 13 deletions.
2 changes: 1 addition & 1 deletion docs/components/Callout.vue
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const activeType = computed(() => {
class="text-sm rounded-xl border px-6 py-4 [&_p]:mb-0 my-4"
:class="activeType.class"
>
<div class="flex items-center gap-2 font-semibold">
<div class="flex items-center gap-2 font-semibold mb-4">
<Icon
class="text-lg"
:icon="activeType.icon"
Expand Down
1 change: 0 additions & 1 deletion docs/components/examples/ComboboxTextarea/list.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ const users = [
{ value: '@folz', listValue: 'folz' },
{ value: '@Slapbox', listValue: 'Slapbox' },
{ value: '@jyash97', listValue: 'jyash97' },
{ value: '@k-sav', listValue: 'k-sav' },
{ value: '@AliLynne', listValue: 'AliLynne' },
{ value: '@DaniGuardiola', listValue: 'DaniGuardiola' },
{ value: '@frassinier', listValue: 'frassinier' },
Expand Down
21 changes: 10 additions & 11 deletions docs/content/docs/guides/migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ import { TooltipPortal, TooltipRoot, TooltipTrigger } from 'reka-ui' // [!code +
```bash
npx codemod reka-ui/import-update
```

</Callout>

## Naming Convention Changes
Expand Down Expand Up @@ -89,11 +89,11 @@ npx codemod reka-ui/update-css-and-data-attributes
```

<Callout type="tip" title="Codemod available">

```bash
npx codemod reka-ui/update-combobox-filter
```

</Callout>

- [Replace `searchTerm` props of Root to Input's `v-model`](https://github.com/radix-vue/radix-vue/commit/e1bab6598c3533dfbf6a86ad26b471ab826df069#diff-833593a5ce28a8c3fabc7d77462b116405e25df2b93bcab449798b5799e73474)
Expand All @@ -103,9 +103,8 @@ npx codemod reka-ui/update-css-and-data-attributes
<template>
<ComboboxRoot v-model:searchTerm="search" :display-value="(v) => v.name" /> // [!code --]
<ComboboxRoot>
// [!code ++]
<ComboboxInput v-model="search" :display-value="(v) => v.name" /> // [!code ++]
</ComboboxRoot> // [!code ++]
</ComboboxRoot>
</template>
```
Expand All @@ -125,11 +124,11 @@ npx codemod reka-ui/update-css-and-data-attributes
```
<Callout type="tip" title="Codemod available">
```bash
npx codemod reka-ui/rename-controlled-state
```
</Callout>
- [Reposition `VisuallyHidden`](https://github.com/radix-vue/radix-vue/commit/107389a9c230d2c94232887b9cbe2710222564aa) - Previously `VisuallyHidden` were position at the root node, causing style scoped to not be applied.
Expand Down Expand Up @@ -165,18 +164,18 @@ npx codemod reka-ui/update-css-and-data-attributes
<CalendarNext :next-page="(date: DateValue) => pagingFunc(date, 1)" /> // [!code ++]
</template>
```
<Callout type="tip" title="Codemod available">
```bash
npx codemod reka-ui/remove-calendar-step-prop
```
</Callout>
### Select
- [`SelectValue` no longer render teleported element](https://github.com/radix-vue/radix-vue/commit/6a623484d610cc3b7c1a23a77c253c8e95cef518) - Previous implmenentation of `SelectValue` will render the selected `SelectItem` via teleporting fragment. This causes SSR flickering, and it is unncessarily computation.
- [`SelectValue` no longer render teleported element](https://github.com/radix-vue/radix-vue/commit/6a623484d610cc3b7c1a23a77c253c8e95cef518) - Previous implmenentation of `SelectValue` will render the selected `SelectItem` via teleporting fragment. This causes SSR flickering, and it is unnecessarily computation.
```vue
<template>
Expand Down

0 comments on commit f574025

Please sign in to comment.