Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update all non-major dependencies #1124

Closed
wants to merge 23 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
54fbbd7
fix(Dialog): aria-description undefined still throwing warning (#1265)
zernonia Sep 3, 2024
0cf2c06
fix(DismissableLayer): branch could be null (#1256)
rankjie Sep 3, 2024
b5c16d2
fix(RovingFocus): wrong focus on group instead of item (#1268)
zernonia Sep 4, 2024
6dbf580
feat: expose virtualizer and virtualized items via slot (#1271)
Dodobibi Sep 6, 2024
ac2772a
fix(RangeCalendar): update start value and end value on modelValue up…
epr3 Sep 11, 2024
27e5a21
chore(deps): update build (#1248)
renovate[bot] Sep 12, 2024
1a721b7
chore(deps): update lint (#1249)
renovate[bot] Sep 12, 2024
f373081
chore(deps): update test (#1250)
renovate[bot] Sep 12, 2024
e6485de
chore(deps): update dependency jsdom to v25 (#1251)
renovate[bot] Sep 12, 2024
3f0f965
fix(Splitter): cursor not reset when component unmount (#1287)
zernonia Sep 12, 2024
ff5abb0
fix(Combobox): stop event propagation on enter (#1279)
ragulka Sep 17, 2024
b6c6fbf
fix(Listbox): horizontal orientation not working (#1299)
zernonia Sep 18, 2024
6d2a924
fix(Listbox): missing aria attributes (#1300)
zernonia Sep 18, 2024
20a755e
refactor: adapt native `useId` (#1298)
zernonia Sep 18, 2024
b398336
docs: add combobox empty (#1301)
ismailsabet Sep 19, 2024
b279b06
fix(Tooltip): showing `v-if` string in aria-label (#1302)
zernonia Sep 19, 2024
7f9555f
chore(deps): update playground (#1291)
renovate[bot] Sep 19, 2024
ca87131
chore(deps): update test to ^2.1.1 (#1293)
renovate[bot] Sep 19, 2024
9e2ff66
chore(deps): update dependency @vitejs/plugin-vue to v5 (#1260)
renovate[bot] Sep 19, 2024
7fee231
chore(deps): update dependency vue-tsc to v2 (#1276)
renovate[bot] Sep 19, 2024
2671726
chore(deps): update build (#1290)
renovate[bot] Sep 19, 2024
5af6ee9
chore: release v1.9.6
zernonia Sep 19, 2024
3232b30
chore(deps): update all non-major dependencies
renovate[bot] Sep 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .histoire/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,18 @@
"vue": "^3.4.31"
},
"devDependencies": {
"@antfu/eslint-config": "^2.26.0",
"@floating-ui/dom": "^1.6.7",
"@floating-ui/vue": "^1.1.0",
"@antfu/eslint-config": "^2.27.3",
"@floating-ui/dom": "^1.6.11",
"@floating-ui/vue": "^1.1.5",
"@histoire/plugin-vue": "^0.17.17",
"@iconify/vue": "^4.1.2",
"@radix-ui/colors": "^3.0.0",
"@rollup/plugin-alias": "^5.1.0",
"autoprefixer": "^10.4.19",
"eslint": "^9.9.0",
"autoprefixer": "^10.4.20",
"eslint": "^9.10.0",
"histoire": "^0.17.17",
"postcss": "^8.4.39",
"tailwindcss": "^3.4.4",
"postcss": "^8.4.47",
"tailwindcss": "^3.4.12",
"tailwindcss-animate": "1.0.7"
}
}
6 changes: 6 additions & 0 deletions docs/content/components/combobox.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,12 @@ The button that clears the search term.

<!-- @include: @/meta/ComboboxCancel.md -->

### Empty

Shown when none of the items match the query.

<!-- @include: @/meta/ComboboxEmpty.md -->

### Portal

When used, portals the content part into the `body`.
Expand Down
2 changes: 1 addition & 1 deletion docs/content/components/dialog.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ If you want to hide the title, wrap it inside our Visually Hidden utility like t

An optional accessible description to be announced when the dialog is opened.

If you want to hide the description, wrap it inside our Visually Hidden utility like this `<VisuallyHidden asChild>`. If you want to remove the description entirely, remove this part and pass `aria-describedby="undefined"` to `DialogContent`.
If you want to hide the description, wrap it inside our Visually Hidden utility like this `<VisuallyHidden asChild>`. If you want to remove the description entirely, remove this part and pass `:aria-describedby="undefined"` to `DialogContent`.

<!-- @include: @/meta/DialogDescription.md -->

Expand Down
4 changes: 4 additions & 0 deletions docs/content/utilities/use-id.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ description: Generate random id

# useId

::: warning Deprecated
[Vue 3.5](https://blog.vuejs.org/posts/vue-3-5#useid) released an official client-server stable solution for `useId`.
:::

<Description>
Generate random id
</Description>
Expand Down
22 changes: 11 additions & 11 deletions docs/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "docs",
"type": "module",
"version": "1.9.5",
"version": "1.9.6",
"scripts": {
"docs:dev": "vitepress dev",
"docs:build": "vitepress build",
Expand All @@ -13,28 +13,28 @@
"typescript": "*"
},
"dependencies": {
"@internationalized/date": "^3.5.4",
"@stackblitz/sdk": "^1.10.0",
"@vueuse/core": "^10.11.0",
"@internationalized/date": "^3.5.5",
"@stackblitz/sdk": "^1.11.0",
"@vueuse/core": "^10.11.1",
"radix-vue": "link:../packages/radix-vue",
"vue": "3.4.31",
"vue-sonner": "^1.1.3"
},
"devDependencies": {
"@babel/traverse": "^7.24.7",
"@babel/traverse": "^7.25.6",
"@iconify/vue": "^4.1.2",
"@radix-ui/colors": "^3.0.0",
"@types/babel__traverse": "^7.20.6",
"@types/markdown-it": "^14.1.1",
"@types/markdown-it": "^14.1.2",
"@vue/tsconfig": "^0.5.1",
"autoprefixer": "^10.4.19",
"autoprefixer": "^10.4.20",
"codesandbox": "^2.2.3",
"fast-glob": "^3.3.2",
"markdown-it": "^14.1.0",
"postcss": "^8.4.39",
"tailwindcss": "^3.4.4",
"tsx": "^4.16.0",
"vitepress": "1.2.3",
"postcss": "^8.4.47",
"tailwindcss": "^3.4.12",
"tsx": "^4.19.1",
"vitepress": "1.3.4",
"vue-component-meta": "^2.0.24"
},
"postcss": {
Expand Down
18 changes: 9 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"name": "radix-vue",
"version": "1.9.5",
"version": "1.9.6",
"private": true,
"packageManager": "pnpm@9.4.0",
"packageManager": "pnpm@9.11.0",
"license": "MIT",
"repository": "radix-vue/radix-vue",
"workspaces": [
Expand All @@ -25,13 +25,13 @@
"pub:release": "cd packages/radix-vue && pnpm pub:release"
},
"devDependencies": {
"@antfu/eslint-config": "^2.26.0",
"@commitlint/cli": "^19.3.0",
"@commitlint/config-conventional": "^19.2.2",
"bumpp": "^9.4.1",
"eslint": "^9.9.0",
"lint-staged": "^15.2.9",
"pnpm": "^9.4.0",
"@antfu/eslint-config": "^2.27.3",
"@commitlint/cli": "^19.5.0",
"@commitlint/config-conventional": "^19.5.0",
"bumpp": "^9.5.2",
"eslint": "^9.10.0",
"lint-staged": "^15.2.10",
"pnpm": "^9.11.0",
"rimraf": "^6.0.1",
"simple-git-hooks": "^2.11.1",
"typescript": "5.3.3"
Expand Down
10 changes: 5 additions & 5 deletions packages/plugins/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "plugins",
"type": "module",
"version": "1.9.5",
"version": "1.9.6",
"description": "Nuxt module for Radix Vue",
"license": "MIT",
"keywords": [
Expand All @@ -18,11 +18,11 @@
"stub": "unbuild --stub"
},
"dependencies": {
"@nuxt/kit": "^3.12.2",
"@nuxt/schema": "^3.12.2",
"@nuxt/kit": "^3.13.2",
"@nuxt/schema": "^3.13.2",
"radix-vue": "link:../radix-vue",
"tsx": "^4.16.0",
"tsx": "^4.19.1",
"unbuild": "^2.0.0",
"unplugin-vue-components": "^0.27.2"
"unplugin-vue-components": "^0.27.4"
}
}
30 changes: 15 additions & 15 deletions packages/radix-vue/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "radix-vue",
"type": "module",
"version": "1.9.5",
"version": "1.9.6",
"description": "Vue port for Radix UI Primitives.",
"author": "Radix Vue Contributors (https://github.com/radix-vue)",
"license": "MIT",
Expand Down Expand Up @@ -93,13 +93,13 @@
"vue": ">= 3.2.0"
},
"dependencies": {
"@floating-ui/dom": "^1.6.7",
"@floating-ui/vue": "^1.1.0",
"@internationalized/date": "^3.5.4",
"@floating-ui/dom": "^1.6.11",
"@floating-ui/vue": "^1.1.5",
"@internationalized/date": "^3.5.5",
"@internationalized/number": "^3.5.3",
"@tanstack/vue-virtual": "^3.8.1",
"@vueuse/core": "^10.11.0",
"@vueuse/shared": "^10.11.0",
"@tanstack/vue-virtual": "^3.10.8",
"@vueuse/core": "^10.11.1",
"@vueuse/shared": "^10.11.1",
"aria-hidden": "^1.2.4",
"defu": "^6.1.4",
"fast-deep-equal": "^3.1.3",
Expand All @@ -108,20 +108,20 @@
"devDependencies": {
"@iconify/vue": "^4.1.2",
"@testing-library/dom": "^10.4.0",
"@testing-library/jest-dom": "^6.4.8",
"@testing-library/jest-dom": "^6.5.0",
"@testing-library/user-event": "^14.5.2",
"@testing-library/vue": "^8.1.0",
"@tsconfig/node18": "^18.2.4",
"@types/node": "^20.14.9",
"@vitejs/plugin-vue": "^5.1.2",
"@types/node": "^20.16.5",
"@vitejs/plugin-vue": "^5.1.4",
"@vitejs/plugin-vue-jsx": "^4.0.1",
"@vitest/coverage-istanbul": "^2.0.5",
"@vitest/coverage-istanbul": "^2.1.1",
"@vue/test-utils": "^2.4.6",
"@vue/tsconfig": "^0.5.1",
"jsdom": "^24.1.1",
"vite": "^5.4.1",
"vite-plugin-dts": "^4.0.3",
"vitest": "^2.0.5",
"jsdom": "^25.0.0",
"vite": "^5.4.6",
"vite-plugin-dts": "^4.2.1",
"vitest": "^2.1.1",
"vitest-axe": "0.1.0",
"vitest-canvas-mock": "^0.3.3",
"vue": "3.4.31",
Expand Down
28 changes: 28 additions & 0 deletions packages/radix-vue/src/Combobox/Combobox.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,19 @@ describe('given combobox in a form', async () => {
props: { handleSubmit },
})

const valueBox = wrapper.find('input')

let enterEventBubbledToForm = false

beforeEach(() => {
enterEventBubbledToForm = false
wrapper.find('form').element.addEventListener('keydown', (event) => {
if (event.key === 'Enter') {
enterEventBubbledToForm = true
}
})
})

it('should have hidden input field', async () => {
expect(wrapper.find('[type="hidden"]').exists()).toBe(true)
})
Expand Down Expand Up @@ -327,6 +340,21 @@ describe('given combobox in a form', async () => {
expect(handleSubmit.mock.results[1].value).toStrictEqual({ test: 'Pineapple' })
})
})

describe('after selecting an option via keyboard', () => {
beforeEach(async () => {
await valueBox.setValue('B')
await valueBox.trigger('keydown', { key: 'Enter' })
})

it('should show value correctly', () => {
expect((valueBox.element).value).toBe('Banana')
})

it('should bubble up the Enter keydown event to the form', () => {
expect(enterEventBubbledToForm).toBe(false)
})
})
})

describe('given a Combobox with 1,000 options', async () => {
Expand Down
10 changes: 7 additions & 3 deletions packages/radix-vue/src/Combobox/ComboboxRoot.vue
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ type ComboboxRootContext<T> = {
inputElement: Ref<HTMLInputElement | undefined>
onInputElementChange: (el: HTMLInputElement) => void
onInputNavigation: (dir: 'up' | 'down' | 'home' | 'end') => void
onInputEnter: () => void
onInputEnter: (event: InputEvent) => void
selectedValue: Ref<T | undefined>
selectedElement: ComputedRef<HTMLElement | undefined>
onSelectedValueChange: (val: T) => void
Expand Down Expand Up @@ -278,9 +278,13 @@ provideComboboxRootContext({

nextTick(() => inputElement.value?.focus({ preventScroll: true }))
},
onInputEnter: async () => {
if (filteredOptions.value.length && selectedValue.value && selectedElement.value instanceof Element)
onInputEnter: async (event) => {
if (filteredOptions.value.length && selectedValue.value && selectedElement.value instanceof Element) {
event.preventDefault()
event.stopPropagation()

selectedElement.value?.click()
}
},
selectedValue,
onSelectedValueChange: val => selectedValue.value = val as T,
Expand Down
2 changes: 1 addition & 1 deletion packages/radix-vue/src/Dialog/DialogContentImpl.vue
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ if (process.env.NODE_ENV !== 'production') {
componentLink: 'dialog.html#title',
titleId: rootContext.titleId,
descriptionId: rootContext.descriptionId,
contentElement: rootContext.contentElement,
contentElement,
})
}
</script>
Expand Down
2 changes: 1 addition & 1 deletion packages/radix-vue/src/Dialog/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ For more information, see https://www.radix-vue.com/components/${componentLink}`

const describedById = contentElement.value?.getAttribute('aria-describedby')
// if we have an id and the user hasn't set aria-describedby="undefined"
if (descriptionId && !describedById) {
if (descriptionId && describedById) {
const hasDescription = document.getElementById(descriptionId)
if (!hasDescription)
console.warn(DESCRIPTION_MESSAGE)
Expand Down
4 changes: 2 additions & 2 deletions packages/radix-vue/src/DismissableLayer/DismissableLayer.vue
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ const isPointerEventsEnabled = computed(() => {

const pointerDownOutside = usePointerDownOutside(async (event) => {
const isPointerDownOnBranch = [...context.branches].some(branch =>
branch.contains(event.target as HTMLElement),
branch?.contains(event.target as HTMLElement),
)

if (!isPointerEventsEnabled.value || isPointerDownOnBranch)
Expand All @@ -117,7 +117,7 @@ const pointerDownOutside = usePointerDownOutside(async (event) => {

const focusOutside = useFocusOutside((event) => {
const isFocusInBranch = [...context.branches].some(branch =>
branch.contains(event.target as HTMLElement),
branch?.contains(event.target as HTMLElement),
)

if (isFocusInBranch)
Expand Down
Loading
Loading