-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Navigation Menu]feat: 1/3 #167
Conversation
@zernonia do you think the navigation menu viewport has any similarity with scroll area's viewport? |
yeah there's some similarity here. By any chance you need help with this? 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several issues:
- When focus is trapped inside navigation menu items, shift+tab on first item should focus back to trigger. 45b81d2
- When focus is trapped inside navigation menu items, pressing tab on last item should focus on next trigger. db60583
- When a menu is opened with keyboard, it cant be closed when clicking outside
- We want to disable loop navigation for the items 45b81d2
- When menu contents are opened and focus is on trigger, tab should go to first trigger item 4af499d
- If pressed tab on final trigger and other menu is opened, it closes the menu and move focuses towards next item like default
The keyboard nav should be similar RadixUI now. I've check against the list above, and seems like work fine! 😁 @khairulhaaziq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so good!
Todos
Related
#14