Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Navigation Menu]feat: 1/3 #167

Merged
merged 19 commits into from
Jul 15, 2023
Merged

[Navigation Menu]feat: 1/3 #167

merged 19 commits into from
Jul 15, 2023

Conversation

k11q
Copy link
Member

@k11q k11q commented Jul 11, 2023

Todos

  • Make modals inside viewport
  • Make arrow center relative to button
  • Make viewport center relative to list container
  • Make viewport dynamic width/height

Related

#14

@k11q
Copy link
Member Author

k11q commented Jul 11, 2023

@zernonia do you think the navigation menu viewport has any similarity with scroll area's viewport?
https://www.radix-ui.com/docs/primitives/components/navigation-menu

@zernonia
Copy link
Member

zernonia commented Jul 12, 2023

@zernonia do you think the navigation menu viewport has any similarity with scroll area's viewport? https://www.radix-ui.com/docs/primitives/components/navigation-menu

yeah there's some similarity here. By any chance you need help with this? 😁

@zernonia zernonia marked this pull request as ready for review July 14, 2023 17:03
@zernonia zernonia marked this pull request as draft July 14, 2023 17:04
@zernonia zernonia marked this pull request as ready for review July 14, 2023 17:54
Copy link
Member Author

@k11q k11q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several issues:

  • When focus is trapped inside navigation menu items, shift+tab on first item should focus back to trigger. 45b81d2
  • When focus is trapped inside navigation menu items, pressing tab on last item should focus on next trigger. db60583
  • When a menu is opened with keyboard, it cant be closed when clicking outside
  • We want to disable loop navigation for the items 45b81d2
  • When menu contents are opened and focus is on trigger, tab should go to first trigger item 4af499d
  • If pressed tab on final trigger and other menu is opened, it closes the menu and move focuses towards next item like default

@zernonia
Copy link
Member

The keyboard nav should be similar RadixUI now. I've check against the list above, and seems like work fine! 😁

@khairulhaaziq

Copy link
Member Author

@k11q k11q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so good!

@k11q k11q merged commit 02a60b0 into main Jul 15, 2023
2 checks passed
@sadeghbarati sadeghbarati deleted the navigation-menu-1/3 branch June 26, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants