-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] ssg/ssr not rendering correctly #233
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k11q
approved these changes
Jul 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ⚡️
onmax
pushed a commit
that referenced
this pull request
Jul 25, 2023
* fix avatar rendering issue * add nuxt playground to demo ssr * fix requestAnimationFrame throwing error * fix element selected even though undefined * fix navigation menu not updating position for indicator correctly
zernonia
added a commit
that referenced
this pull request
Jul 25, 2023
* [Tooltip] feat: Added props to TooltipArrow * useHoverDelay accept callbacks and options * Updated useHover * Updated PopperContent * [Tooltip] Finished API * [Accordion]feat: 2/3 (#211) * [Accordion]feat: 2/3 * Added useSingleOrMultipleValue * [Accordion]fix: Check if item is disabled onClick * [useSingleOrMultipleValue] fix: use defaultValue from props * [AccordionStory] fix: Use collapsible for single type * [Accordion] fix: Remove unnecessary type in inject * [Bug] ssg/ssr not rendering correctly (#233) * fix avatar rendering issue * add nuxt playground to demo ssr * fix requestAnimationFrame throwing error * fix element selected even though undefined * fix navigation menu not updating position for indicator correctly * chore: release v0.1.10 * [Tooltip]fix : tooltip open on keyboard focus (#238) * [Tooltip]fix: bind props values to data-side and data-align, remove unnecessary question mark (#237) * [Alert Dialog]fix : Alert Dialog handle click outside (#236) * Fix : Alert Dialog handle click outside * Fix : remove event handler * chore: release 0.1.11 * [Tooltip] feat: Removed TooltipPortal in favor of Teleport * [Tooltip] feat: Use flg disable on hover * Tooltip: Define emits event in TooltipContent * Tooltip: Create stories folder * Tooltip: Fixed content story * Revert HoverCard changes * Use VisuallyHidden component * run lint * fix triggerElement missing, test some story props --------- Co-authored-by: zernonia <[email protected]> Co-authored-by: khairulhaaziq <[email protected]> Co-authored-by: Misbah Ansori <[email protected]> Co-authored-by: Artem Melnyk <[email protected]> Co-authored-by: zernonia <[email protected]>
misbahansori
added a commit
to misbahansori/radix-vue
that referenced
this pull request
Jul 26, 2023
* [Tooltip] feat: Added props to TooltipArrow * useHoverDelay accept callbacks and options * Updated useHover * Updated PopperContent * [Tooltip] Finished API * [Accordion]feat: 2/3 (unovue#211) * [Accordion]feat: 2/3 * Added useSingleOrMultipleValue * [Accordion]fix: Check if item is disabled onClick * [useSingleOrMultipleValue] fix: use defaultValue from props * [AccordionStory] fix: Use collapsible for single type * [Accordion] fix: Remove unnecessary type in inject * [Bug] ssg/ssr not rendering correctly (unovue#233) * fix avatar rendering issue * add nuxt playground to demo ssr * fix requestAnimationFrame throwing error * fix element selected even though undefined * fix navigation menu not updating position for indicator correctly * chore: release v0.1.10 * [Tooltip]fix : tooltip open on keyboard focus (unovue#238) * [Tooltip]fix: bind props values to data-side and data-align, remove unnecessary question mark (unovue#237) * [Alert Dialog]fix : Alert Dialog handle click outside (unovue#236) * Fix : Alert Dialog handle click outside * Fix : remove event handler * chore: release 0.1.11 * [Tooltip] feat: Removed TooltipPortal in favor of Teleport * [Tooltip] feat: Use flg disable on hover * Tooltip: Define emits event in TooltipContent * Tooltip: Create stories folder * Tooltip: Fixed content story * Revert HoverCard changes * Use VisuallyHidden component * run lint * fix triggerElement missing, test some story props --------- Co-authored-by: zernonia <[email protected]> Co-authored-by: khairulhaaziq <[email protected]> Co-authored-by: Misbah Ansori <[email protected]> Co-authored-by: Artem Melnyk <[email protected]> Co-authored-by: zernonia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor case which we didnt consider during SSR/SSG