Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ssg/ssr not rendering correctly #233

Merged
merged 5 commits into from
Jul 23, 2023

Conversation

zernonia
Copy link
Member

Some minor case which we didnt consider during SSR/SSG

@zernonia zernonia linked an issue Jul 23, 2023 that may be closed by this pull request
@zernonia zernonia requested a review from k11q July 23, 2023 09:54
@zernonia zernonia self-assigned this Jul 23, 2023
Copy link
Member

@k11q k11q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ⚡️

@k11q k11q merged commit 6146b06 into main Jul 23, 2023
3 checks passed
onmax pushed a commit that referenced this pull request Jul 25, 2023
* fix avatar rendering issue

* add nuxt playground to demo ssr

* fix requestAnimationFrame throwing error

* fix element selected even though undefined

* fix navigation menu not updating position for indicator correctly
zernonia added a commit that referenced this pull request Jul 25, 2023
* [Tooltip] feat: Added props to TooltipArrow

* useHoverDelay accept callbacks and options

* Updated useHover

* Updated PopperContent

* [Tooltip] Finished API

* [Accordion]feat: 2/3 (#211)

* [Accordion]feat: 2/3

* Added useSingleOrMultipleValue

* [Accordion]fix: Check if item is disabled onClick

* [useSingleOrMultipleValue] fix: use defaultValue from props

* [AccordionStory] fix: Use collapsible for single type

* [Accordion] fix: Remove unnecessary type in inject

* [Bug] ssg/ssr not rendering correctly (#233)

* fix avatar rendering issue

* add nuxt playground to demo ssr

* fix requestAnimationFrame throwing error

* fix element selected even though undefined

* fix navigation menu not updating position for indicator correctly

* chore: release v0.1.10

* [Tooltip]fix : tooltip open on keyboard focus (#238)

* [Tooltip]fix: bind props values to data-side and data-align, remove unnecessary question mark (#237)

* [Alert Dialog]fix : Alert Dialog handle click outside (#236)

* Fix : Alert Dialog handle click outside

* Fix : remove event handler

* chore: release 0.1.11

* [Tooltip] feat: Removed TooltipPortal in favor of Teleport

* [Tooltip] feat: Use flg disable on hover

* Tooltip: Define emits event in TooltipContent

* Tooltip: Create stories folder

* Tooltip: Fixed content story

* Revert HoverCard changes

* Use VisuallyHidden component

* run lint

* fix triggerElement missing, test some story props

---------

Co-authored-by: zernonia <[email protected]>
Co-authored-by: khairulhaaziq <[email protected]>
Co-authored-by: Misbah Ansori <[email protected]>
Co-authored-by: Artem Melnyk <[email protected]>
Co-authored-by: zernonia <[email protected]>
misbahansori added a commit to misbahansori/radix-vue that referenced this pull request Jul 26, 2023
* [Tooltip] feat: Added props to TooltipArrow

* useHoverDelay accept callbacks and options

* Updated useHover

* Updated PopperContent

* [Tooltip] Finished API

* [Accordion]feat: 2/3 (unovue#211)

* [Accordion]feat: 2/3

* Added useSingleOrMultipleValue

* [Accordion]fix: Check if item is disabled onClick

* [useSingleOrMultipleValue] fix: use defaultValue from props

* [AccordionStory] fix: Use collapsible for single type

* [Accordion] fix: Remove unnecessary type in inject

* [Bug] ssg/ssr not rendering correctly (unovue#233)

* fix avatar rendering issue

* add nuxt playground to demo ssr

* fix requestAnimationFrame throwing error

* fix element selected even though undefined

* fix navigation menu not updating position for indicator correctly

* chore: release v0.1.10

* [Tooltip]fix : tooltip open on keyboard focus (unovue#238)

* [Tooltip]fix: bind props values to data-side and data-align, remove unnecessary question mark (unovue#237)

* [Alert Dialog]fix : Alert Dialog handle click outside (unovue#236)

* Fix : Alert Dialog handle click outside

* Fix : remove event handler

* chore: release 0.1.11

* [Tooltip] feat: Removed TooltipPortal in favor of Teleport

* [Tooltip] feat: Use flg disable on hover

* Tooltip: Define emits event in TooltipContent

* Tooltip: Create stories folder

* Tooltip: Fixed content story

* Revert HoverCard changes

* Use VisuallyHidden component

* run lint

* fix triggerElement missing, test some story props

---------

Co-authored-by: zernonia <[email protected]>
Co-authored-by: khairulhaaziq <[email protected]>
Co-authored-by: Misbah Ansori <[email protected]>
Co-authored-by: Artem Melnyk <[email protected]>
Co-authored-by: zernonia <[email protected]>
@sadeghbarati sadeghbarati deleted the 228-bug-ssgssr-not-rendering-correctly branch June 26, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: SSG/SSR not rendering correctly.
2 participants