Improve build and publish workflow #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR @Elliot-Alexander ! Any updates on this? 😁 |
Elliot-Alexander
force-pushed
the
add-commitlint
branch
4 times, most recently
from
674c4a2
to
11ca5f2
Compare
Elliot-Alexander
force-pushed
the
add-commitlint
branch
from
11ca5f2
to
5ac7a02
Compare
|
Hey @zernonia, just pushed my first attempt at the CI workflow; have outlined above the changes. I might merge this PR with my other open one re: prettier (which I'll replace with Antfu's eslint) if that sounds alright to you. We can discuss the release workflow on Discord later as will need to coordinate you adding tokens to the repo secrets. |
|
Looking good @Elliot-Alexander ! I think let's not merge this with Prettier. Since that PR shouldn't update any pipeline, and just provide a shared eslint among the packages 😁 |
Elliot-Alexander
force-pushed
the
add-commitlint
branch
from
5ac7a02
to
2c72bb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently just adds commitlint, will add workflow changes soon, been busy with work 🙃Related Issue
#247
Motivation and Context
#247
How Has This Been Tested?
Screenshots (if appropriate):
Check my current branch to see applicable workflow runs :)