[Popover]feat: 2/3(Complete API)

[onmax]

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

TODO

• If we have a stack of dialogs, one on top of other, we have to make sure to handle events correctly and no trigger all of them at same time

[onmax]

Sorry @zernonia for bothering.

I am updating the Popover with the DismissableLayer and the FocusScope.

But I am getting the following error in the 4df79d0 commit

I would appreciate a help on this. I am trying to follow the code from Menu but I didn't see where the error is.

[zernonia]

Sorry @zernonia for bothering.

I am updating the Popover with the DismissableLayer and the FocusScope.

But I am getting the following error in the 4df79d0 commit

I would appreciate a help on this. I am trying to follow the code from Menu but I didn't see where the error is.

Hey @onmax .. I've commented here yaa.. But not sure if that's the cause...

[onmax]

@zernonia I feel overwhelmed. I have a lot of work to do for my job atm.

I tried to finish this component, but I am lost. I need time to focus and understand the new changes like DismissableLayer and FocusScope.

Before having those components, I was implementing the Popover with composables rather than renderless components.

With this change of paradigm, I need to rethink how to implement for example the disabled flag for the Popover and I have no idea where to start. I have to make multiple changes like that, and I basically don't have the time.

So please, feel free to take over so we can mark this feature as done. Otherwise, I will be working on Radix Vue in 10 days or so. 😄

Thanks

[zernonia]

@zernonia I feel overwhelmed. I have a lot of work to do for my job atm.

So please, feel free to take over so we can mark this feature as done. Otherwise, I will be working on Radix Vue in 10 days or so. 😄

Thanks

I sorry to hear that you are overwhelmed at work. Yeah I can help made those changes yaa.. I've decided to go with those 2 renderless component (instead of composables) because they expose emits behaviour that could be prevented using preventDefault(), and it sticks closer to the RadixUI API.

No worry ya.. I can have a look at this 😁

[zernonia]

Thanks for the PR @onmax . I've created another PR (#312), and ported some of your code there.. I will close this PR for further reference for some composables that you've created 😁