refactor: use get-tsconfig instead of tsconfig-paths
#880
Conversation
update ora, remove unsed semver
| export async function getRawConfig(cwd: string): Promise<RawConfig | null> { | ||
| try { | ||
| const configResult = await c12LoadConfig({ | ||
| name: 'components', | ||
| configFile: 'components.json', | ||
| configFile: 'components', |
There was a problem hiding this comment.
changed again to components so user could use any supported format in unjs/c12 for components.json/json5/... file
packages/cli/src/commands/init.ts
Outdated
| @@ -139,7 +139,7 @@ export async function promptForConfig( | |||
| message: (prev, values) => `Where is your ${highlight(values.typescript ? 'tsconfig.json' : 'jsconfig.json')} file?`, | |||
| initial: (prev, values) => { | |||
| const prefix = values.framework === 'nuxt' ? '.nuxt/' : './' | |||
| const path = values.typescript ? 'tsconfig.json' : 'jsconfig.json' | |||
| const path = values.framework === 'nuxt' ? 'tsconfig.json' : values.typescript ? 'tsconfig.json' : 'jsconfig.json' | |||
There was a problem hiding this comment.
If the framework is Nuxt, CLI initial value must be .nuxt/tsconfig.json
But the current CLI is using .nuxt/jsconfig.json in JS projects
There was a problem hiding this comment.
What is the reason of using .nuxt/tsconfig.json instead of base ./tsconfig.json for a Nuxt project? If get-tsconfig correctly resolves extends, then the result will be the same, right?
The advantage of using base ./tsconfig.json could be in respecting any other custom options user provided in this file. But I'm not sure how exactly tsconfig is used by shadcn-vue except the path resolving, so maybe I'm wrong.
There was a problem hiding this comment.
Yeah you are right, we can simplify the prefix and path variables
I did not test with base ./tsconfig.json in root of the Nuxt project but it should work. maybe with both
./tsconfig.jsonor./jsconfig.json
{
// https://nuxt.com/docs/guide/concepts/typescript
"extends": "./.nuxt/tsconfig.json"
}.nuxt/tsconfig.json
|
This PR will be included in the Next PR #917 So closing |
🔗 Linked issue
Close #291
Close #806
Close #560
Close #559
Close #430 (not sure about WSL, but it must be fixed)
❓ Type of change
📚 Description
#291 (comment)
Please feel free to push new changes
Also, I did not update the test files