Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Reponsive Breadcrumb Example #933

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

damienroche
Copy link
Contributor

@damienroche damienroche commented Dec 2, 2024

πŸ”— Linked issue

#932

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

In the Responsive example, if there are fewer links than the itemsToDisplay value, the first breadcrumb is displayed twice.

πŸ“Έ Screenshots

Screenshot 2024-12-02 at 11:47:00

Proposed solution:

We need to add an additional check in the remainingItems computed variable to handle this edge case.

+ const remainingItems = computed(() => items.value.slice(-Math.min(itemsToDisplay, items.value.length) + 1))
- const remainingItems = computed(() => items.value.slice(-itemsToDisplay + 1))

Close #932

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@damienroche damienroche changed the title Breadcrumbs Update Reponsive Breadcrumb Example Dec 2, 2024
@sadeghbarati sadeghbarati merged commit 857f10d into unovue:dev Dec 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Fix Remaining Items to display in Breadcrumb Responsive example
2 participants