Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable biome detection in generated components.d.ts #792

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wChenonly
Copy link

Description

useExportType Some checking tools will report errors

All exports are only types and should thus use export type.biomelint/style/useExportType

Linked Issues

Additional context

@wChenonly wChenonly requested a review from antfu as a code owner August 14, 2024 01:34
Copy link

stackblitz bot commented Aug 14, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@wChenonly wChenonly changed the title chore: export type in declaration.ts fix: export type in declaration.ts Aug 14, 2024
@antfu
Copy link
Member

antfu commented Aug 14, 2024

I would feel it's something biome side should improve. Also it's meaningless to lint a generated file tbh, I think we could have the control comment for biome to disable that, like we have for the other tools like eslint and prettier

@wChenonly
Copy link
Author

I would feel it's something biome side should improve. Also it's meaningless to lint a generated file tbh, I think we could have the control comment for biome to disable that, like we have for the other tools like eslint and prettier

now disable biome by commenting it out, but for syntactical reasons we can only put it after Read more: for now.

@wChenonly wChenonly changed the title fix: export type in declaration.ts fix: disable biome detection in generated components.d.ts Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants