Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #129. For now the text content must be supplied as per the example instead of via stdin; a change here could be covered by #110.
There isn't really a satisfying way to format ICU messages across newlines. In this example the space between the
hasTags
andanother
interpolations needs to be preserved exactly as-is. Equally formatting in callbacks would be ambiguous, whereas the newlines and indentation inserted here aren't because it's within the syntactic structure of the interpolations.I think this is okay because as per the feature request, and the part of the example I borrowed from there, we'll mostly be using this for interpolation-heavy, flattened messages.
In terms of implementation, the bulk of the change is refactoring the ICU compiler to be a little more abstract. Following that the change to support formatting is straightforward and centralised, essentially just using
Reader
local
to increment a count according to how deeply nested into "cases" in the AST we are and inserting formatting accordingly.