Switch to new cluster and build credentials #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhh
reviewed
Jan 8, 2024
| @@ -25,6 +25,12 @@ jobs: | |||
| # Docker is preinstalled. | |||
| run: nix build .#dockerImage && ./result | docker load | |||
|
|
|||
| - name: Assume AWS role | |||
| uses: aws-actions/configure-aws-credentials@v4 | |||
There was a problem hiding this comment.
Just commenting early to say that I've been trying to avoid unnecessary use of actions as they're proprietary to GitHub, making the code less portable to other CI systems. They often do little more than a line or two of shell.
There was a problem hiding this comment.
Thanks for the feedback. Even though I do not agree I will take it in consideration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.